MyBB Community Forums - Fixed Bugs

[F] [UCP] HTML in link not valid [C-StefanT]

Thu, 13 Aug 2009 17:54:56 +0000

Just a tiny issue. In the file usercp.php find:

$leavelink = "post_code}\">".$lang->usergroup_leave."
";

& should be &

[F] [search.php] PHP error

Thu, 13 Aug 2009 17:52:29 +0000

If you enter just one of the following symbols into the search field you get an sql error: . , [ ]

Quote:Warning [2] Invalid argument supplied for foreach() - Line: 256 - File: inc/functions_search.php

[F] [WOL] - do_addsubscription, removesubscriptions [C-StefanT]

Wed, 12 Aug 2009 17:42:11 +0000

In the functions_online.php are 2 mistakes of the usercp2. At first there is a missing "s" by one of the 2 "removesubscription" and the "do_addsubscription" is totally missing. The reaction to this should be clear: In the WOL it's shown as "Unknown Location"

			elseif($parameters['action'] == "addsubscription" || $parameters['action'] == "removesubscription" || $parameters['action'] == "removesubscription")
			{
				$user_activity['activity'] = "usercp2_subscriptions";
			}

Should be

			elseif($parameters['action'] == "addsubscription" || $parameters['action'] == "do_addsubscription" || $parameters['action'] == "removesubscription" || $parameters['action'] == "removesubscriptions")
			{
				$user_activity['activity'] = "usercp2_subscriptions";
			}

[F] search finduserthreads problem with limit [C-StefanT]

Thu, 06 Aug 2009 20:40:47 +0000

From profile there are 2 options.
1. Find All Threads
2. Find All Posts

If you have limit set for search results.

If you Find All Posts the results display the newest posts first.

BUG: If you Find All Threads the results display the oldest threads first and cut off the new threads because of order.

If no limit is set then the search results do indeed display newest threads first. So this is related to limit.

You can see example from HF on my own profile.

Possible fix:

search.php

if(intval($mybb->settings['searchhardlimit']) > 0)
{
	$limitsql = "LIMIT ".intval($mybb->settings['searchhardlimit']);
}

Change to:

if(intval($mybb->settings['searchhardlimit']) > 0)
{
	$limitsql = "ORDER BY dateline DESC LIMIT ".intval($mybb->settings['searchhardlimit']);
}

Please confirm my fix but I looked as good as I can for any possible side effect problems.

[F] stats.php PHP error [C-StefanT]

Wed, 05 Aug 2009 00:32:01 +0000

On my localhost 1.4.8 installation I get this:

Warning [2] number_format() expects parameter 1 to be double, string given - Line: 3666 - File: C:\wamp\www\mybb\mybb14x_public_mysql\inc\functions.php PHP 5.3.0 (WINNT)
File Line Function
[PHP] errorHandler->error
C:\wamp\www\mybb\mybb14x_public_mysql\inc\functions.php 3666 number_format
C:\wamp\www\mybb\mybb14x_public_mysql\stats.php 177 my_number_format

And, this is in the stats: Today's top poster: Nobody ( posts)

There's no number. It appears to be a PHP 5.3.0 error, doesn't happen in 5.2.9-2, and I can't reproduce on the SVN; whether that's because it's been fixed there, or I just haven't got the same conditions to reproduce on the SVN, I'm not entirely sure.

Feel free to mark as bogus if it has indeed already been fixed.

[F] db Backup Task Bug(s) [C-StefanT]

Sat, 01 Aug 2009 22:03:28 +0000

I found this easy to replicate on more than one host, and didn't see other reports:

1a) If you are in edit task
index.php?module=tools/tasks&action=edit&tid=4
and choose "enable" the system does not give a warning.

1b) If you are in task manger
index.php?module=tools/tasks
and use the drop-down menu to enable, then the system gives a warning
"WARNING: You are about to enable a task that is only meant to be run via a cron (Please see the MyBB Wiki for more information). Continue?"

2) Is it really intended to be run only by cron?

If so, how about a link in admin cp which leads to a simple page that explains you can use backupdb.php, if it is set by cron?
Why have it listed in the automated tasks area (where cron isn't normally needed)?

3) The backup works when using the "run this task now" button, but does not seem to ever work when run as a task.

###
Note:
#1a and 1b I am certain about.
#2 is a question to clarify the issue.
#3 needs more testing.

Thank you

[F] Merged Accounts and Join Date [C-StefanT]

Sat, 01 Aug 2009 04:21:38 +0000

When you merge members it takes the join date of the destination account. I would think it makes more sense to use the oldest date instead. This may or may not be counted as a bug and if not please move into suggestion area instead of bogus please.

Quote:Here you can merge two user accounts in to one. The "Source Account" will be merged in to the "Destination Account" leaving only the destination account. The source accounts posts, threads, private messages, calendar events, post count and buddy list will be merged in to the destination account.

I see nothing about warning that join date might be effected negatively.

Thank you for considering this.

[F] Copy forum - forum can have no parent

Mon, 27 Jul 2009 20:26:30 +0000

When copying a forum it's possible to have a forum, not a category, with no parent.

To reproduce, from the forum management page, choose a normal forum, not category, click Options, and then Copy Forum. Leave everything as it is, particularly the 'Destination forum' which is 'Copy to new forum' by default, keep the new forum type as a forum, and the 'Parent Forum' as None. Give the new forum a title, and save.

forumwithnoparent1.png (Size: 51.2 KB / Downloads: 745)

The names aren't in bold so they're just forums, but they have no parent.

Screenshot of the settings:

forumwithnoparent2.png (Size: 36.68 KB / Downloads: 740)

Again, marked as a forum, but no parent.

If you then try and edit and/or save a forum made in this way once it's been created, you get the usual 'You must select a parent forum' error.

[F] ACP - group # of users when using additional groups bug [C-StefanT]

Fri, 24 Jul 2009 15:43:04 +0000

I've noticed that in the administration control panel when viewing groups, the # of users in each group is wrong because it wasn't counting any users that had the groups listed as additional groups. I think the problem is in the admin\modules\users\groups.php file in the query:

default:
	$query = $db->query("
		SELECT g.gid, COUNT(u.uid) AS users
		FROM ".TABLE_PREFIX."users u
		LEFT JOIN ".TABLE_PREFIX."usergroups g ON (CONCAT(',', u.additionalgroups, ',') LIKE CONCAT('%,', g.gid, ',%'))
		WHERE g.gid != '0' AND g.gid != NULL GROUP BY g.gid

the !=NULL should be is not null. The query is also in the sqllite case statement I'm guessing it should be changed in that also but I'm using mysql so I couldn't test that one.

Thanks

[F] Buddy List no longer shows invisible users as online [C-StefanT]

Wed, 22 Jul 2009 07:15:08 +0000

In 1.2 a user who had the right to see invisible users could see them in the who's online list and also in their buddy list as being online.

In 1.4.8. a user who has the right to see invisible users can still see them in the who's online list, with an asterisk next to their name as before, but they can no longer see those users as online in their buddy list. They now show as offline, even though the who's online list shows that they are online.

Surely this is a bug in 1.4.8. A user who can see invisible users as online in the who's online list should surely also see them as online in their buddy list? Otherwise, the information is contradictory.

It worked OK in 1.2, and since the change in 1.4.8. gives contradictory information about whether another user is online or offline, I can only assume that this is a bug in 1.4.8.

[F] Syndication: Atom and RSS different time [C-StefanT]

Tue, 21 Jul 2009 20:53:24 +0000

Hi,

it seems that RSS feed and Atom feed shows different times:

http://community.mybboard.net/syndication.php
http://community.mybboard.net/syndicatio...pe=atom1.0

In this board 5 hours. The Atom feed seems to ignore the time difference.

[F] Hard-coded language string in admin/modules/user/admin_permissions.php [R] [C-StefanT]

Tue, 21 Jul 2009 13:51:17 +0000

MyBB 1.4.8, file admin/modules/user/admin_permissions.php, line 331

			$table->construct_cell("Set Permissions", array("class" => "align_center"));

the "Set Permissions" string should be included in language files so that we could translate it.

[F] Board Statistics inconsistency [C-StefanT]

Mon, 13 Jul 2009 07:25:58 +0000

As it says, just an inconsistency, not really a bug but thought I'd point it out anyway...

The "Most popular forum" link is given as:
http://community.mybboard.net/forumdisplay.php?fid=4
Whereas it should be:
http://community.mybboard.net/forum-4.html

Similar sort of thing happens on my forums too.

/me runs away.

[F] deprecated magic_quotes with PHP 5.3

Sun, 12 Jul 2009 11:09:21 +0000

MyBB has experienced an internal error and cannot continue.

Error Type:
(8192)
Error Message:
Function set_magic_quotes_runtime() is deprecated
Location:
File: D:\wamp\www\mybb\inc\class_core.php
Line: 163
Code:
160. $this->strip_slashes_array($_GET);
161. $this->strip_slashes_array($_COOKIE);
162. }
163. set_magic_quotes_runtime(0);
164. @ini_set("magic_quotes_gpc", 0);
165. @ini_set("magic_quotes_runtime", 0);
166.

MyBB has experienced an internal error and cannot continue.

Error Type:
(8192)
Error Message:
Assigning the return value of new by reference is deprecated
Location:
File: D:\wamp\www\mybb\admin\modules\style\templates.php
Line: 1199
Code:
1196. require_once MYBB_ROOT."inc/3rdparty/diff/Diff.php";
1197. require_once MYBB_ROOT."inc/3rdparty/diff/Diff/Renderer/inline.php";
1198.
1199. $diff = &new Text_Diff('auto', array($template1['template'], $template2['template']));
1200. $renderer = &new Text_Diff_Renderer_inline();
1201.
1202. if($sid)

[F] System mail log: Wrong multipage links [C-StefanT]

Sat, 11 Jul 2009 00:55:05 +0000

If you search your system mail logs and the result is on several pages there's a problem with the links in the pagination:
index.php?module=tools/mailerrors&page=2subject=xyz

The & is missing and because of that it shows all logs if you switch between the pages.

admin/modules/tools/mailerrors.php

$additional_criteria = implode("&", $additional_criteria);
...
echo "
".draw_admin_pagination($mybb->input['page'], $per_page, $total_rows, "index.php?module=tools/mailerrors&page={page}{$additional_criteria}");