[F] incorrect subforum count

[WDZ]

When a forum has more subforums than MyBB is configured to display, and they don't all have the same display order, the "and x more" count can be wrong or not displayed at all.

For example, on a test board I have this setup:

   

But when I view the index I see:

   

It should say "Sub Forums: Sub 1, Sub 2, and 2 more."


Note: the Admin CP does show the correct "more" text, but only because of this bug in /admin/modules/forum/management.php:

PHP Code:

foreach($forum_cache as $forum)
{
    $forums_by_parent[$forum['pid']][$val['disporder']][$forum['fid']] = $forum;
} 


($val should be $forum)

Funny how one bug can actually "fix" another bug...

BTW, the same $val['disporder'] bug also exists in these files due to copy-and-paste:

/admin/modules/forum/announcements.php
/inc/functions_modcp.php

[Ryan Gordon]

This is only reproducible when there are different Display orders in the same parent

[Ryan Gordon]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

[WDZ]

(08-19-2008 06:36 AM)Ryan Gordon Wrote:  This is only reproducible when there are different Display orders in the same parent

Right, I already said that. Isn't it a good practice to give every subforum a unique display order? I always do.