Current time: 05-24-2012, 12:23 PM Hello There, Guest! (LoginRegister)


 
Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
[F] url with brackets [C-Michael83]
10-04-2008, 09:11 AM (This post was last modified: 10-18-2008 12:52 PM by Yumi.)
Post: #1
[F] url with brackets [C-Michael83]
that must be a bug:

urls containing brackets are not completley shown
Example:

Code:
http://www.airlinetest.com/index.php?id=topdetails&no_cache=1&uid=447&tx_ttnews[swords]=Lufthansa

as a link: http://www.airlinetest.com/index.php?id=...&tx_ttnews[swords]=Lufthansa

Someone has a solution?

Thanks
RII

http://www.info-tunesien.de
German Site about Tunisia!
Find all posts by this user
10-04-2008, 01:00 PM (This post was last modified: 10-04-2008 01:00 PM by Yumi.)
Post: #2
RE: url with brackets
Those characters aren't valid in URLs, so it's not a bug...

(most browsers convert "[" to "%5B" and "]" to "%5D" - therefore, the correct URL for the above is:
http://www.airlinetest.com/index.php?id=...=Lufthansa )
Visit this user's website Find all posts by this user
10-04-2008, 01:50 PM
Post: #3
RE: url with brackets
(10-04-2008 01:00 PM)ZiNgA BuRgA Wrote:  Those characters aren't valid in URLs, so it's not a bug...

(most browsers convert "[" to "%5B" and "]" to "%5D" - therefore, the correct URL for the above is:
http://www.airlinetest.com/index.php?id=...=Lufthansa )

Yea most browsers convert them so why shouldn't it be fixed?
Convert [] to &5B and %5D, so that users don't have to. And if you just write [] in an url the browser will recognize it so I don't see why this shouldn't be fixed.
Find all posts by this user
10-05-2008, 11:19 PM
Post: #4
RE: [B] url with brackets
We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/
Visit this user's website Find all posts by this user
10-06-2008, 07:33 AM
Post: #5
RE: [B] url with brackets
(10-05-2008 11:19 PM)ZiNgA BuRgA Wrote:  We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
Find all posts by this user
10-06-2008, 07:52 AM (This post was last modified: 10-06-2008 07:54 AM by Dennis Tsang.)
Post: #6
RE: [B] url with brackets
http://www.airlinetest.com/index.php?id=...=Lufthansa

Dennis Tsang :: MyBB Developer
Follow me on Twitter: @dennistt
Visit this user's website Find all posts by this user
10-06-2008, 05:14 PM
Post: #7
RE: [B] url with brackets
(10-06-2008 07:52 AM)DennisTT Wrote:  http://www.airlinetest.com/index.php?id=...=Lufthansa

Okey so it doesn't work inside the url tags either. Shouldn't it?
Find all posts by this user
10-06-2008, 10:40 PM (This post was last modified: 10-06-2008 10:40 PM by Yumi.)
Post: #8
RE: [B] url with brackets
(10-06-2008 07:33 AM)CraKteR Wrote:  
(10-05-2008 11:19 PM)ZiNgA BuRgA Wrote:  We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
Possibly, but then [http://google.com] would break...

Inside the URL tag should probably be fixed though I guess, though I like sticking to URL standards. (easy fix, just remove the []'s from the regex).
Visit this user's website Find all posts by this user
10-07-2008, 11:00 AM
Post: #9
RE: [B] url with brackets
(10-06-2008 10:40 PM)ZiNgA BuRgA Wrote:  
(10-06-2008 07:33 AM)CraKteR Wrote:  
(10-05-2008 11:19 PM)ZiNgA BuRgA Wrote:  We can't fix everything.
It's problematic - there's no way to tell if the brackets inserted for the auto URL was intentional or not.

For example:

Visit http://google.com[best search engine]
http://example.com(my website)
https://somesite.com/

oh, I thought it was when using the [url] tag.
Anyways, people should be able to use space after a url anyways.
Possibly, but then [http://google.com] would break...

Inside the URL tag should probably be fixed though I guess, though I like sticking to URL standards. (easy fix, just remove the []'s from the regex).

Well then you should convert the []'s. As they are supported. And every browser converts them to [] and if you copy it it will be [].
Find all posts by this user
10-18-2008, 12:49 PM (This post was last modified: 10-18-2008 12:52 PM by Yumi.)
Post: #10
RE: [F] url with brackets
Okay, I've added some URL entity fixes for URLs inside [url] tags. Would anyone be able to confirm that these changes don't break anything?
(replace inc/class_parser.php with the supplied file)

Thanks!


Attached File(s)
.php  class_parser.php (Size: 29.66 KB / Downloads: 235)
Visit this user's website Find all posts by this user


Forum Jump:


User(s) browsing this thread: 1 Guest(s)

Contact Us | MyBB | Return to Top | Return to Content | Lite (Archive) Mode | RSS Syndication