[F] Mail Reply Address: Issue Resolved

[Ryan Gordon]

classixiii, do those SMTP errors occur when you are sending a thread or emailing a user?

If so, can you try this patch?

in both member.php and sendthread.php find

PHP Code:

$from = "{$mybb->user['username']} <{$mybb->user['email']}>"; 


and replace with

PHP Code:

if($mybb->settings['mail_handler'] == 'smtp')
{
    $from = $mybb->user['email'];
}
else
{
    $from = "{$mybb->user['username']} <{$mybb->user['email']}>";
} 


[classixiii]

(11-16-2008 08:47 AM)Ryan Gordon Wrote:  classixiii, do those SMTP errors occur when you are sending a thread or emailing a user?

If so, can you try this patch?

in both member.php and sendthread.php find

PHP Code:

$from = "{$mybb->user['username']} <{$mybb->user['email']}>"; 


and replace with

PHP Code:

if($mybb->settings['mail_handler'] == 'smtp')
{
    $from = $mybb->user['email'];
}
else
{
    $from = "{$mybb->user['username']} <{$mybb->user['email']}>";
} 


The problem was both in sending a thread and emailing a user.

After making the above changes, several test mails were sent received with no error in the system email log.

Here is a paste from the SMTP log

235 Authentication succeeded
250 OK
250 Accepted
354 Enter message, ending with "." on a line by itself
250 OK id=1L1udy-0001BM-8N
220-*****.*****.com ESMTP Exim 4.68 #1 Sun, 16 Nov 2008 21:25:28 -0600
220-We do not authorize the use of this system to transport unsolicited,
220 and/or bulk e-mail.
250-*****.*****.com Hello mail.miurareps.net [**.**.***.**]
250-SIZE 52428800
250-PIPELINING
250-AUTH PLAIN LOGIN
250-STARTTLS
250 HELP


Thanks for all the help!

[Ryan Gordon]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group

[classixiii]

Thanks Again...

There were actually (2) separate issues fixed here.
PHP mail and SMTP mail

Perhaps it would be helpful to rename the thread so other people searching for this fix could find it easier ?

Just a thought !