MyBB

koziolek · (This post was last modified: 01-28-2009 08:41 AM by koziolek.)

MyBB 1.4.4
Rebuilding Thread Counters with large Entries per page (e.g > 5000; with overall threads above 100000) fails with "Allowed memory size of 64 MB exhausted".

Memory usage grows because of static $thread_cache in get_thread() which holds every thread. This is not necessary - we do not have to cache every thread... So maybe limit the size of $thread_cache?

Proof of concept with hard limit (solves the issue, but there can be more elegant solutions) in patch.

bobbit · 01-28-2009, 11:23 AM

This also happens with attachment rebuilding.

Ryan Gordon · 01-28-2009, 03:00 PM

How about just limit of the size of your per page? This seems bogus because your the one forcing it to process so many at one time, not us

koziolek · 01-28-2009, 03:29 PM

Good luck with recounting 130 000 threads with 500 per page... and 130 000 is not a big number - there are bigger boards...

Sergio Montoya · 01-28-2009, 06:44 PM

We have the defaults between 100 and 200 for a reason. That would be not a bug, but your server unable to handle that much at the same time.

Ryan Gordon · (This post was last modified: 01-28-2009 09:47 PM by Ryan Gordon.)

(01-28-2009 03:29 PM)koziolek Wrote: Good luck with recounting 130 000 threads with 500 per page... and 130 000 is not a big number - there are bigger boards...

Yep. And those bigger boards have been correctly configured. I should know, since I help run one of them. In fact it is approximately 30 times bigger then yours and recount and rebuilds run smooth and fast.

You need to configure your server correctly if you want to do more then MyBB's default values for recounting.

bobbit · 01-28-2009, 11:56 PM

Can the recounting process at least be automated, rather than having to click on a button every time?

Ryan Gordon · 01-29-2009, 12:01 AM

(01-28-2009 11:56 PM)bobbit Wrote: Can the recounting process at least be automated, rather than having to click on a button every time?

That's a good idea. Can you post it on the suggestions forum or the ideas site?

bobbit · 01-29-2009, 12:07 AM

Done.

Also added a little something else in but it's not necessary.

koziolek · (This post was last modified: 01-29-2009 10:24 AM by koziolek.)

(01-28-2009 09:44 PM)Ryan Gordon Wrote: You need to configure your server correctly if you want to do more then MyBB's default values for recounting.

First: By configuring server correctly you mean raising up memory_limit? Heh... The memory usage of any script should not raise above some level. No matter what value the user passes to a script. App should still behave correctly with proper memory footprint. User can set "10000 entries per page" and the application can timeout (max execution time) but it cannot eat MB of memory. As I said once here - lazy and bad programming cannot be an excuse for buying more memory...

Second: Anyway, it is a hosting.