Quick Reply "Loading..." Doesn't go away...

[atomicj]

I want to keep the ajax, I just want to remove the loading screen that shows up..

[Tomm M]

I can't guarantee this will work, and I suggest that this is merely a temporary fix to the problem. Hopefully upgrading to 1.4.5 when it comes out will solve your issues.

In ./jscripts/thread.js, you'll find circa line 332:

Code:

        this.quick_replying = 1;
        var post_body = Form.serialize('quick_reply_form');
        this.spinner = new ActivityIndicator("body", {image: imagepath + "/spinner_big.gif"});

Remove...

Code:

this.spinner = new ActivityIndicator("body", {image: imagepath + "/spinner_big.gif"});

This code is called whenever the spinner appears. It's used (unsurprisingly) to show that the page is loading, and a user shouldn't do anything. It is fairly generic, and you'll find it elsewhere in the javascript files. If you want to remove it from other functions (such as quick editing a post) feel free to delete it. It shouldn't provide any javascript errors as there's nothing dependent on it. Each section of code has a if(this.spinner) to check if exists first.

[atomicj]

Sweet.. thanks Tom..

Like you mentioned "It's used to show that the page is loading, and a user shouldn't do anything".. That is an issue if it doesn't go away.. That will really confuse some people.

I don't think it's a major thing to have anyway. It shouldn't be an issue not having it.

Thanks again

[Tomm M]

Your welcome

I think in some cases the server doesn't send a response to say it's completed the action properly, but don't quote me on that. That means the spinner is never removed, and sticks.

When 1.4.5 is released, upgrade as normal and then (if the js file isn't replaced in the upgrade) update the js file and just see if that fixes it. If not, there isn't any harm in removing it I guess...