[F] Validation Issue [C-Chris W B.]

[Tomm M]

There's a small html validation issue with forum names. If I'm being too picky, then mark this as bogus - I know a few MyBB pages don't validate either.

Take a look at this thread. Notice the title:

Code:

<title>Bug test &amp; Stuff</title>

But, notice the navigation (esp: Testing & Trashing):

Code:

<div class="navigation">
<a href="http://community.mybboard.net/index.php">MyBB Community Forums</a>
/
<a href="forum-12.html">General Discussion</a>
/
<a href="forum-13.html">Testing & Trashing</a>
/
<span class="active">Bug test &amp; Stuff</span>
</div>

To fix this, I would suggest this change. In ./inc/functions.php, find (around line 2888):

PHP Code:

                $navsize = count($navbits);
                $navbits[$navsize]['name'] = $forumnav['name']; 


Replace with:

PHP Code:

                $navsize = count($navbits);
                $navbits[$navsize]['name'] = htmlspecialchars_uni($forumnav['name']); 


The forumdisplay is also effected: http://community.mybboard.net/forum-13.html - I'm thinking it's because the forum name isn't put through htmlspecialchars_uni like other pages (like showthread - note Bug test & Stuff).

Code:

<title>MyBB Community Forums - Testing & Trashing </title>

Code:

            <div>
                <strong>Testing & Trashing</strong>
            </div>

Suggest after

PHP Code:

$parentlist = $foruminfo['parentlist']; 


adding

PHP Code:

$parentlist = $foruminfo['parentlist'];
$foruminfo['name'] = htmlspecialchars_uni($foruminfo['name']); 


I think that cures this problem.

[Tomm M]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group