[F] Syndication.php MySQL Error (Limit Option) [R] [C-StefanT]

[iNJECTOR™]

Hi,

Some of my friends was founded this bug (Low Level) on syndication.php.

its for limit option. if lower than -1 it will be error.

i edited this file and here i attached the patch for this bug.

Simple bug : http://community.mybboard.net/syndication.php?limit=-1

[Tomm M]

Thanks for reporting this, iNJECTOR. Although I think I'll do this:

PHP Code:

// Find out the thread limit.
$thread_limit = intval($mybb->input['limit']);
if($thread_limit > 50)
{
    $thread_limit = 50;
}
else if(!$thread_limit)
{
    $thread_limit = 20;
} 


To:

PHP Code:

// Find out the thread limit.
$thread_limit = intval($mybb->input['limit']);
if($thread_limit > 50)
{
    $thread_limit = 50;
}
else if(!$thread_limit || $thread_limit < 0)
{
    $thread_limit = 20;
} 


[Tomm M]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group