[F] System mail log: Wrong multipage links [C-StefanT]

[Michael S.]

If you search your system mail logs and the result is on several pages there's a problem with the links in the pagination:
index.php?module=tools/mailerrors&page=2subject=xyz

The & is missing and because of that it shows all logs if you switch between the pages.

admin/modules/tools/mailerrors.php

PHP Code:

$additional_criteria = implode("&", $additional_criteria);
...
echo "<br />".draw_admin_pagination($mybb->input['page'], $per_page, $total_rows, "index.php?module=tools/mailerrors&amp;page={page}{$additional_criteria}"); 


[Tomm M]

Can't $additional_criteria just be changed to:

PHP Code:

$additional_criteria = "&".implode("&", $additional_criteria); 


...or is that just me being lazy?...

[Martin M.]

(07-15-2009 09:24 AM)Tomm M Wrote:  Can't $additional_criteria just be changed to:

PHP Code:

$additional_criteria = "&".implode("&", $additional_criteria); 


...or is that just me being lazy?...

It would be cleaner to have it in the echo line imho.

[Tomm M]

But if there is no additional criteria, the page URL would be "index.php?module=tools/mailerrors&page=2&"...

[Martin M.]

It still would be with your solution.

[Tomm M]

Touché...

[Ryan Gordon]

PHP Code:

if($additional_criteria)
{
$additional_criteria = "&".implode("&", $additional_criteria);
} 


?

[Ryan Gordon]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group