Current time: 07-23-2014, 05:46 AM Hello There, Guest! (LoginRegister)


[F] System mail log: Wrong multipage links [C-StefanT]
07-11-2009, 12:55 AM
Post: #1
[F] System mail log: Wrong multipage links [C-StefanT]
If you search your system mail logs and the result is on several pages there's a problem with the links in the pagination:
index.php?module=tools/mailerrors&page=2subject=xyz

The & is missing and because of that it shows all logs if you switch between the pages.

admin/modules/tools/mailerrors.php
PHP Code:
$additional_criteria implode("&"$additional_criteria);
...
echo 
"<br />".draw_admin_pagination($mybb->input['page'], $per_page$total_rows"index.php?module=tools/mailerrors&amp;page={page}{$additional_criteria}"); 

Greets,
Michael
-------------
[Image: donation_drive_sig.png]
Visit this user's website Find all posts by this user
07-15-2009, 09:24 AM
Post: #2
RE: System mail log: Wrong multipage links
Can't $additional_criteria just be changed to:

PHP Code:
$additional_criteria "&amp;".implode("&amp;"$additional_criteria); 

...or is that just me being lazy?... Toungue
Find all posts by this user
07-15-2009, 11:25 AM
Post: #3
RE: System mail log: Wrong multipage links
(07-15-2009 09:24 AM)Tomm M Wrote:  Can't $additional_criteria just be changed to:

PHP Code:
$additional_criteria "&amp;".implode("&amp;"$additional_criteria); 

...or is that just me being lazy?... Toungue

It would be cleaner to have it in the echo line imho.
Find all posts by this user
07-15-2009, 11:43 AM
Post: #4
RE: System mail log: Wrong multipage links
But if there is no additional criteria, the page URL would be "index.php?module=tools/mailerrors&page=2&"...
Find all posts by this user
07-15-2009, 11:46 AM
Post: #5
RE: System mail log: Wrong multipage links
It still would be with your solution.
Find all posts by this user
07-15-2009, 12:00 PM
Post: #6
RE: System mail log: Wrong multipage links
Touché... Toungue
Find all posts by this user
07-15-2009, 05:37 PM
Post: #7
RE: System mail log: Wrong multipage links
PHP Code:
if($additional_criteria)
{
$additional_criteria "&amp;".implode("&amp;"$additional_criteria);


?
Visit this user's website Find all posts by this user
08-08-2009, 05:38 AM
Post: #8
[F] System mail log: Wrong multipage links
Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group
Visit this user's website Find all posts by this user


Forum Jump:


User(s) browsing this thread: 1 Guest(s)

Contact Us | MyBB | Return to Top | Return to Content | Lite (Archive) Mode | RSS Syndication