MyBB Community Forums

Full Version: A potential security issue was found in the template. Please review your changes
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Im using 1.6.4

This is the first time I came across this after upgrading. I went to Templates & Style > Templates > "My Template" > Header

I modified nothing, i just clicked save but it gave me this error:

Quote:The following errors were encountered:

* A potential security issue was found in the template. Please review your changes or contact the MyBB Group for support.
Please paste the contents of your header template here.
--This post has been edited because the issue has been solved. Please take a look at posts below for the problem that may fix your issue as well.--
I'm going to guess the issue is {$pending_joinrequests}. Since 1.6.4, the template system checks for odd looking variables in templates when you save them. It seems to recognise underscores and they trip the alarm (I have a plugin that needs updating to remove the issue too).
What's {$pending_joinrequests} do anyway?

Edit: And removing it didn't fix it...
Ok, it's not that then. It may well be the {$mybb->settings['#']} ones (there are a couple of them). Try removing all of them.
Hmm thats weird, removing the

Quote:<!-- OLD CODES
<li><a href="{$mybb->settings['homeurl']}"><img src="{$theme['imgdir']}/toplinks/home.png" alt="Home">&nbsp;Home&nbsp;</a></li>
<li><a href="{$mybb->settings['bburl']}"><img src="{$theme['imgdir']}/toplinks/forums.png" alt="Forums">&nbsp;Forums&nbsp;</a></li>
<li><a href="{$mybb->settings['#']}"><img src="{$theme['imgdir']}/toplinks/demo.png" alt="Demo">&nbsp;Test 1&nbsp;</a></li>
<li><a href="{$mybb->settings['#']}"><img src="{$theme['imgdir']}/toplinks/purchase.png" alt="Purchase">&nbsp;Test 2&nbsp;</a></li>
-->


fixed it Wink
Yeah you're right, it was the

Quote:{$mybb->settings['#']}
that was causing the problem. Thanks!!