MyBB Community Forums

If I can have my HeaderInclude template Quality Checked, that'd be great, thanks guys

------------------------------------------------------------------------

<link rel="alternate" type="application/rss+xml" title="{$lang->latest_threads} (RSS 2.0)" href="{$mybb->settings['bburl']}/syndication.php" />
<link rel="alternate" type="application/atom+xml" title="{$lang->latest_threads} (Atom 1.0)" href="{$mybb->settings['bburl']}/syndication.php?type=atom1.0" />
<meta http-equiv="Content-Type" content="text/html; charset={$charset}" />
<meta http-equiv="Content-Script-Type" content="text/javascript" />
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/prototype.js?ver=1600"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/general.js?ver=1600"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/popup_menu.js?ver=1600"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/thumbspostrating.js?ver=1600"></script><link type="text/css" rel="stylesheet" href="{$mybb->settings['bburl']}/css/thumbspostrating.css" />
{$stylesheets}
<script type="text/javascript">
<!--
	var cookieDomain = "{$mybb->settings['cookiedomain']}";
	var cookiePath = "{$mybb->settings['cookiepath']}";
	var cookiePrefix = "{$mybb->settings['cookieprefix']}";
	var deleteevent_confirm = "{$lang->deleteevent_confirm}";
	var removeattach_confirm = "{$lang->removeattach_confirm}";
	var loading_text = '{$lang->ajax_loading}';
	var saving_changes = '{$lang->saving_changes}';
	var use_xmlhttprequest = "{$mybb->settings['use_xmlhttprequest']}";
	var my_post_key = "{$mybb->post_code}";
	var imagepath = "{$theme['imgdir']}";
// -->
</script>
{$newpmmsg}
{$mystatus_js}
<script language="javascript" type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/myadvertisements.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/jquery/1.8.0/jquery.min.js"></script>
<script>
    jQuery.noConflict();
</script>
<script src="http://code.jquery.com/jquery-latest.js"></script>
<script>
    jQuery.noConflict();
</script>
<script type="text/javascript">
 jQuery.noConflict();
 </script>

At a quick glance, I see a few things:

<script src="//ajax.googleapis.com/ajax/libs/jquery/1.8.0/jquery.min.js"></script>
<script>
    jQuery.noConflict();
</script>
<script src="http://code.jquery.com/jquery-latest.js"></script>
<script>
    jQuery.noConflict();
</script>
<script type="text/javascript">
 jQuery.noConflict();
 </script> 

You include jQuery twice and noConflict it three times. Try this:

<script src="http://code.jquery.com/jquery-latest.js"></script>
<script type="text/javascript">
 jQuery.noConflict();
 </script> 

What all do you mean by quality check?

(2012-09-22, 03:02 AM)Paul H. Wrote: [ -> ]At a quick glance, I see a few things:

<script src="//ajax.googleapis.com/ajax/libs/jquery/1.8.0/jquery.min.js"></script>
<script>
    jQuery.noConflict();
</script>
<script src="http://code.jquery.com/jquery-latest.js"></script>
<script>
    jQuery.noConflict();
</script>
<script type="text/javascript">
 jQuery.noConflict();
 </script> 

You include jQuery twice and noConflict it three times. Try this:

<script src="http://code.jquery.com/jquery-latest.js"></script>
<script type="text/javascript">
 jQuery.noConflict();
 </script> 

What all do you mean by quality check?

Ok thanks Paul, I will change.

I want to make sure I have what I need and remove what I don't need.

Anything else or all looks good?

I'm unsure about this:

<meta http-equiv="Content-Script-Type" content="text/javascript" />

This will be better off in the showthread template:

<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/thumbspostrating.js?ver=1600"></script><link type="text/css" rel="stylesheet" href="{$mybb->settings['bburl']}/css/thumbspostrating.css" />