MyBB Community Forums

MyBB Community Forums > Development > Suggestions and Feedback > Template "Search and Replace" when Replace is empty
Full Version: Template "Search and Replace" when Replace is empty
You're currently viewing a stripped down version of our content. View the full version with proper formatting.

Qiao

2013-12-22, 01:14 AM
Please, consider adding checkbox for replace in Template Search/Replace.

I have bad feeling every time I click "Find and Replace" when replace is empty. It is like replace with empty string.


"Find" and "Find and Replace" should be clearly separated.

Destroy666

2013-12-22, 01:28 AM
Wrong base, should be in 1.6/1.8 suggestions, not in support...

But I agree. Leaving it empty seemed confusing for me too - I didn't know whether it would remove or just find the text without doing anything. I always copied Find input content to Replace input when I wanted to find something, just to be sure.

Nathan Malcolm

2013-12-22, 05:04 AM
It's not on our roadmap but if you (or anyone else) wants to, we'll be happy to accept a pull request. Smile

Qiao

2013-12-22, 05:39 PM
That would be great, how pull request is made?

Nathan Malcolm

2013-12-22, 05:49 PM
(2013-12-22, 05:39 PM)Qiao Wrote: [ -> ]That would be great, how pull request is made?

See: https://help.github.com/articles/creatin...ll-request

and: https://help.github.com/articles/using-pull-requests

You should also read the README which can be found here: https://github.com/mybb/mybb/
MyBB Community Forums > Development > Suggestions and Feedback > Template "Search and Replace" when Replace is empty