MyBB Community Forums

Full Version: issue in smilies parser
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3
Hi,
I create new Smilie with "Text to Replace"
:))
Now When I use it, it is parsed to Smile)
Please see this:
I can confirm... maybe this should be consider in https://github.com/mybb/mybb/issues/902
I don't see why you'd create a smiley where the replacement text is already matched by another.
This is not a bug. If you were to change the display order so that your custom smilie was less than any conflicting smilies you would not receive this issue.
(2014-07-17, 06:44 PM)JordanMussi Wrote: [ -> ]This is not a bug. If you were to change the display order so that your custom smilie was less than any conflicting smilies you would not receive this issue.
But This is a bug, display order is the order to show It's not parser order!
I think MyBB Should sort smilies in reverse order for parsing.
Why? That would break every forum that has set smilies up correctly.
I'll have to reject this, sorry.

PS. Make sure to read the description of the Display Order field. It says explicitly that it matters for the ordering in the list, not in the parsing process.
I could have sworn that the cache was ordered by display order (thus the parsing process will be in that order)...
By parsing I didn't mean when parsing posts but in the actual editor Smile
Oh... Blush
Perhaps we should use xmlhttp.php to make sure the editor parses the same as normal post view would...
Pages: 1 2 3