MyBB Community Forums

Full Version: Small improvements in theme
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
Theme of 1.8 has same small issue of apart theme of 1.6

With plugin myalert, dropdown not appear correctly:

[Image: u2TiiNs.png]

So if made small change in theme

In global.css

Find:

#panel .lower {
	background: #efefef;
	color: #999;
	border-top: 1px solid #fff;
	border-bottom: 1px solid #ccc;
	padding: 5px;
	overflow: hidden;
}

Replace:


#panel .lower {
	background: #efefef;
	color: #999;
	border-top: 1px solid #fff;
	border-bottom: 1px solid #ccc;
	padding: 5px;
}

In header_welcomeblock_member template find:

		</ul>
	</div>
</div>

Replace:

		</ul>
	</div>
	<br style="clear: both;" />	
</div>

Fixes above is same of this http://community.mybb.com/thread-127444-...#pid925565

with fixes:

[Image: fs5TTEu.png]

If nobody is against this modification please modify.
though i would personally like this change, wonder why should the base theme include changes to support a plugin....
I agree, make it easier - notification system is missing in mybb 1.8 so this plugin is really useful Wink

EDIT: MyAlerts needs some GUI improvements for 1.8.
(2014-07-20, 06:25 AM)mmadhankumar Wrote: [ -> ]though i would personally like this change, wonder why should the base theme include changes to support a plugin....

this issue is of apart theme of 1.6... 1.8 theme is based in apart theme...
default theme of 1.6 not has this issue...
(2014-07-20, 06:25 AM)mmadhankumar Wrote: [ -> ]though i would personally like this change, wonder why should the base theme include changes to support a plugin....

It's not only to support a plugin but also to make future customizations easier (for example adding a custom drop down menu in panel).
Moreover, My Alerts is a very popular plugin and there may be a lot of help topics about this issue.
(2014-07-20, 12:38 PM)Adriano Wrote: [ -> ]
(2014-07-20, 06:25 AM)mmadhankumar Wrote: [ -> ]though i would personally like this change, wonder why should the base theme include changes to support a plugin....

It's not only to support a plugin but also to make future customizations easier (for example adding a custom drop down menu in panel).
Moreover, My Alerts is a very popular plugin and there may be a lot of help topics about this issue.

exactly... this will avoid a lot thread of same thing...
i agree
I support this change....
I support it too
I don't see why not, guess you can make a PR for this. But please use class="clear" for <br /> like the other templates do instead of inline style.
Pages: 1 2