2014-08-21, 03:51 PM
inline_edit.js line 20
to
new content in headerinclude
after
add
Even if spinner image can be changed (from gif to any other image) img tag is still hardcoded. For theme developers who are using glyph icons (like Font Awesome) in themes adding image file for this variable would be a waste since spinning animation can be added to anything. pseudo selectors (::before and ::after) won't work on img tag (if they could work it's not a problem to add img[src*="spinner.gif"] {display:none;} to global.css and use pseudo selector to attach a glyph icon). Since it's a very low issue is it possible to push it in 1.8.0 milestone (2 small edits are needed) ? I have tested this with 2 themes (default and custom one), it works like a charm.
Quote:indicator: '<img src="'+spinner_image+'">',
to
Quote:indicator: spinner,
new content in headerinclude
after
Quote: var spinner_image = "{$theme['imgdir']}/spinner.gif";
add
var spinner = "<img src='" + spinner_image +"' />";
Even if spinner image can be changed (from gif to any other image) img tag is still hardcoded. For theme developers who are using glyph icons (like Font Awesome) in themes adding image file for this variable would be a waste since spinning animation can be added to anything. pseudo selectors (::before and ::after) won't work on img tag (if they could work it's not a problem to add img[src*="spinner.gif"] {display:none;} to global.css and use pseudo selector to attach a glyph icon). Since it's a very low issue is it possible to push it in 1.8.0 milestone (2 small edits are needed) ? I have tested this with 2 themes (default and custom one), it works like a charm.