2014-09-09, 03:12 PM
Hi,
in modcp.php?action=banuser I find a bug.
if We only one banned group MyBB use <input type="hidden" for banned group but value of it is last gid!
for fix:
in modcp.php
find:
and in install/resources/mybb_theme.xml
find:
in modcp.php?action=banuser I find a bug.
if We only one banned group MyBB use <input type="hidden" for banned group but value of it is last gid!
for fix:
in modcp.php
find:
$bangroup_option = $bangroups = '';
$numgroups = 0;
$groupscache = $cache->read("usergroups");
foreach($groupscache as $key => $group)
{
if($group['isbannedgroup'])
{
$selected = "";
if(isset($banned['gid']) && $banned['gid'] == $group['gid'])
{
$selected = " selected=\"selected\"";
}
$group['title'] = htmlspecialchars_uni($group['title']);
eval("\$bangroup_option .= \"".$templates->get("modcp_banuser_bangroups_group")."\";");
++$numgroups;
}
}
if($numgroups > 1)
{
eval("\$bangroups = \"".$templates->get("modcp_banuser_bangroups")."\";");
}
else
{
eval("\$bangroups = \"".$templates->get("modcp_banuser_bangroups_hidden")."\";");
}
replace to:
$bangroup_option = $bangroups = '';
$numgroups = 0;
$groupscache = $cache->read("usergroups");
$banned_group = 0;
foreach($groupscache as $key => $group)
{
if($group['isbannedgroup'])
{
$selected = "";
if(isset($banned['gid']) && $banned['gid'] == $group['gid'])
{
$selected = " selected=\"selected\"";
}
$group['title'] = htmlspecialchars_uni($group['title']);
eval("\$bangroup_option .= \"".$templates->get("modcp_banuser_bangroups_group")."\";");
$banned_group = $group['gid'];
++$numgroups;
}
}
if($numgroups > 1)
{
eval("\$bangroups = \"".$templates->get("modcp_banuser_bangroups")."\";");
}
else
{
eval("\$bangroups = \"".$templates->get("modcp_banuser_bangroups_hidden")."\";");
}
and in install/resources/mybb_theme.xml
find:
<template name="modcp_banuser_bangroups_hidden" version="1800"><![CDATA[<input type="hidden" name="usergroup" value="{$group['gid']}" />]]></template>
Replace to:<template name="modcp_banuser_bangroups_hidden" version="1801"><![CDATA[<input type="hidden" name="usergroup" value="{$banned_group}" />]]></template>