Isn't a bug, if you see the thread with an administration account, you will see the "New reply" button, and the quick reply will be light-red.
But if you see the thread with a normal account, the button change to "closed" and you can't reply.
You're right but I think a link to a not permision page isn't useful!
(2014-09-15, 01:05 PM)My-BB.Ir Wrote: [ -> ]You're right but I think a link to a not permision page isn't useful!
What do you mean? If you can reply to the closed thread (so there shouldn't be 'no permission' page), showthread_newreply is displayed. If you can't reply to it, showthread_newreply_closed is shown instead. This is intended and it works fine for me. Could you elaborate?
(2014-09-15, 04:05 PM)Destroy666 Wrote: [ -> ] (2014-09-15, 01:05 PM)My-BB.Ir Wrote: [ -> ]You're right but I think a link to a not permision page isn't useful!
What do you mean? If you can reply to the closed thread (so there shouldn't be 'no permission' page), showthread_newreply is displayed. If you can't reply to it, showthread_newreply_closed is shown instead. This is intended and it works fine for me. Could you elaborate?
Now,
if (thread is closed && you can reply to closed threads) { You see "New Reply" button }
if(thread is closed && you can't reply to closed threads) { You see "Closed Thread" button => "Closed thread" button links to a "No Permission" }
(2014-09-15, 05:18 PM)Destroy666 Wrote: [ -> ]Oh, I see, but then your PR doesn't fix it because the link is inside the showthread_newreply_closed template: https://github.com/mybb/mybb/blob/featur...xml#L11328
It always linked to a no permission page as far as I remember, so I'm not sure if it should be considered a bug. But I agree that removing it would be better.
EDIT: ^ yep, 1.6.x had it like this too: https://github.com/mybb/mybb/blob/master....xml#L3713
I said: "Thread Closed" button should display for peoples can reply to closed threads and don't display anything for others.
IIRC it redirected to an error_no_permission() page in 1.6 but now it uses an error() page. Unsure why the change.
Basically, the page/button is there to encourage users to register/login, which doesn't really happens with the error() page.
(2014-09-15, 07:18 PM)My-BB.Ir Wrote: [ -> ] (2014-09-15, 05:18 PM)Destroy666 Wrote: [ -> ]Oh, I see, but then your PR doesn't fix it because the link is inside the showthread_newreply_closed template: https://github.com/mybb/mybb/blob/featur...xml#L11328
It always linked to a no permission page as far as I remember, so I'm not sure if it should be considered a bug. But I agree that removing it would be better.
EDIT: ^ yep, 1.6.x had it like this too: https://github.com/mybb/mybb/blob/master....xml#L3713
I said: "Thread Closed" button should display for peoples can reply to closed threads and don't display anything for others.
But then the people won't be able to see that the thread is closed from showthread - the button provides that information. Not a good solution, the current code is better.
If anything should be changed, then I'd remove the link from the button, nothing else.
Maybe better to add a new button for users with permissions to reply to closed threads