MyBB Community Forums

I'm not causing problems, im speaking about the plugin you claim to be your own. I check plugins i install and i notice things and it started with the dirty refresh you passed at the top of your file.

It's not your code, that's why your overly defensive, if your not doing anything wrong then why are you so defensive and stating people are causing problems?

I guess these are real problems:

Dirty Refresh:

if(!defined("IN_MYBB"))
{
die("<meta http-equiv=\"refresh\" content=\"0;URL=http://notionbb.com\">");
}

Yours:

foreach($addSpider as $spider)
{
if(!in_array($spider['useragent'], $knownspiders))
{
$spiders_group = array(
'name'	=> addslashes($spider['name']),
'useragent'	=> addslashes($spider['useragent']),
);
$db->insert_query("spiders", $spiders_group);
}

His

foreach($addSpider as $spider)
{
	// If doesn't already exist in the table, then add it
	if(!in_array($spider['useragent'], $knownspiders))
	{
		// Now add each spider
	$spiders_group = array(
		'name'		=> addslashes($spider['name']),
		'useragent'		=> addslashes($spider['useragent']),
	);
		$db->insert_query("spiders", $spiders_group);
	}
}

Yours

unset($addSpider, $spider, $knownspiders);

His

unset($addSpider, $spider, $knownspiders);

Yours

foreach($addSpider as $spider)
{
$spiders_group = array(
'name'	=> addslashes($spider['name']),
);
$db->write_query("DELETE FROM ".TABLE_PREFIX."spiders WHERE name='".$spiders_group['name']."'");
}	

His

foreach($addSpider as $spider)
{


		// Now delete each spider
	$spiders_group = array(

		'name'		=> addslashes($spider['name']),

	);
		$db->write_query("DELETE FROM ".TABLE_PREFIX."spiders WHERE name='".$spiders_group['name']."'");
			

}	

Yet, his came out in 2009 at least you can do is man up to stealing it. I'm not even the author of the original version either, however what you did is indeed very arrogant.

(2014-11-07, 01:29 PM)Depressurize Wrote: [ -> ]I'm not causing problems, im speaking about the plugin you claim to be your own. I check plugins i install and i notice things and it started with the dirty refresh you passed at the top of your file.

It's not your code, that's why your overly defensive, if your not doing anything wrong then why are you so defensive and stating people are causing problems?

I guess these are real problems:

Dirty Refresh:

if(!defined("IN_MYBB"))
{
die("<meta http-equiv=\"refresh\" content=\"0;URL=http://notionbb.com\">");
}

Yours:

foreach($addSpider as $spider)
{
if(!in_array($spider['useragent'], $knownspiders))
{
$spiders_group = array(
'name'	=> addslashes($spider['name']),
'useragent'	=> addslashes($spider['useragent']),
);
$db->insert_query("spiders", $spiders_group);
}

His

foreach($addSpider as $spider)
{
	// If doesn't already exist in the table, then add it
	if(!in_array($spider['useragent'], $knownspiders))
	{
		// Now add each spider
	$spiders_group = array(
		'name'		=> addslashes($spider['name']),
		'useragent'		=> addslashes($spider['useragent']),
	);
		$db->insert_query("spiders", $spiders_group);
	}
}

Yours

unset($addSpider, $spider, $knownspiders);

His

unset($addSpider, $spider, $knownspiders);

Yours

foreach($addSpider as $spider)
{
$spiders_group = array(
'name'	=> addslashes($spider['name']),
);
$db->write_query("DELETE FROM ".TABLE_PREFIX."spiders WHERE name='".$spiders_group['name']."'");
}	

His

foreach($addSpider as $spider)
{


		// Now delete each spider
	$spiders_group = array(

		'name'		=> addslashes($spider['name']),

	);
		$db->write_query("DELETE FROM ".TABLE_PREFIX."spiders WHERE name='".$spiders_group['name']."'");
			

}	

Yet, his came out in 2009 at least you can do is man up to stealing it. I'm not even the author of the original version either, however what you did is indeed very arrogant.

So you came on here to point out my coding and such? I don't steal plugins from MyBB and name them mine. I actually code them out myself. You are trying to troll me on a product site.

Here...I added more bots for the next version. MyBB Spiders Stop trying to cause problems with me.

We're looking into it - as long as the license allows forks everything is ok. I'll close this thread if you don't stop with that discussion

Go for it. I'm only seeing problems with this.

(2014-11-07, 01:02 PM)Depressurize Wrote: [ -> ]Not a bad idea, however i noticed something and i'm surprised you don't announce your doing this nor why mybb validated this.

if(!defined("IN_MYBB"))
{
die("<meta http-equiv=\"refresh\" content=\"0;URL=http://notionbb.com\">");
}

Advertising is not disallowed as long as the plugin works as it should - noone forces anyone to use a modification which adds backlinks or similar stuff. And this form isn't even obtrusive - it would redirect people only if they try to access a file which they never should access directly. The probability of that is very very low.


As for the old plugin, @Philip, you don't respect the license if you use someone's code, enhance it a bit and then claim it as your own. Proper credits to the original author should be left in tact, otherwise I'll have to delete your submission.

As I said, go for it. I'm only seeing problems with this and as for the plugin. I don't look at the old mod site. I have no reason to do so...so I didn't know there was one already name for it...okay maybe the codes are a bit similar but I didn't steal them.

(2014-11-07, 01:36 PM)Destroy666 Wrote: [ -> ]Advertising is not disallowed as long as the plugin works as it should - noone forces anyone to use a modification which adds backlinks or similar stuff. And this form isn't even obtrusive - it would redirect people only if they try to access a file which they never should access directly. The probability of that is very very low.

I agree, but if one is doing this they should have some partial moral here and atleast inform people. As a prime example even if it is a 0.0001%

Let's say i have this installed and then you goto it on my site. Then let's say his site has sort of a auto downloading trojan, malware or even spyware or he got hacked. Then what?

Regardless of what the user was trying to do by viewing the plugin, he still at the end of the day came and got infected through my site, that leaves a bitter taste in peoples mouths.

As for credits, that's all i was really trying to get at with him but he got defensive and it led nowhere. Forking is 1 thing, stealing is another i'm glad you recognize that

Kind regards,
- Depressurize

Delete all the plugins of mine. Cause I know I am going to continue to be harassed by this.

Since the discussion kept going, this is being locked while we look into it.

(2014-11-07, 01:42 PM)Depressurize Wrote: [ -> ]Let's say i have this installed and then you goto it on my site. Then let's say his site has sort of a auto downloading trojan, malware or even spyware or he got hacked. Then what?

Well, I understand your point, but with this logic we shouldn't accept anything that relies on 3rd party sites, including FB like buttons (their JS may get infected someday, who knows) and other common modifications.

EDIT: locked since dragonexpert forgot.