MyBB Community Forums

Hi folks,

this is not really a suggestion but more of a development discussion so not sure if someone wants to move it to the Discussion board, but I don't see a point in excluding most of the community from this thread
 
Maybe I'm the only one, but I find it really annoying that lots of PR on GitHub are named "Fix #abcd". Reading those titles in my notification overview isn't informative, so there is no possibility to find out on what people were working but clicking on every single notification... 

My suggestion: add a paragraph to the contribution guidelines about naming of pull requests. 


Nik

Agreed for definite. I'm subscribed to emails for PRs and issues. Getting emails titled things like "Fix #195" means nothing

agree...
for me better something this https://github.com/mybb/mybb/pull/1599
i alway put same title of ticket.

Most developers already use meaningful titles: https://github.com/mybb/mybb/pulls?q=is%3Apr

Fixes XX + title - it would be enough

(2014-11-23, 08:50 PM)StefanT Wrote: [ -> ]Most developers already use meaningful titles: https://github.com/mybb/mybb/pulls?q=is%3Apr

But most developers do is not enough  There are still some PR left, that do not use meaningful titles^^

This rule should be only for new PRs

(2014-11-24, 06:50 PM)Eldenroot Wrote: [ -> ]This rule should be only for new PRs

sure, but when there are still developers left, who do not use reasonable names, there will always be pull requests without reasonable names  

Well, as one of them I can start to CTRL+C a part of the issue titles if you really want.

Pull requests should indeed have a clear and understandable title. Otherwise there will be thousands of issues which can't be easily searched for and it'll be a PITA for others in the future when tracking down changes and issues.