MyBB Community Forums

Recent threads from post author


This plugin allows users to view recent threads from current post author.

Plugin Name: Recent threads from post author


Plugin Author: Harshit
Plugin Version: 1.0
Plugin Mybb Compatibility: 1.6x,1.8x
Plugin Description: Shows recent threads from post author

This plugin allows users to view recent threads from current post author.





Downloads
http://community.mybb.com/mods.php?actio...ad&pid=330

Note for downloaders: the plugin is not optimised and will use X + 1 queries per showthread, where X is "Number of posts to show", while only 1 is needed.

No, it works completely fine without any problem.

(2014-12-11, 05:00 AM)Harshit Wrote: [ -> ]No, it works completely fine without any problem.

That doesn't mean it's optimised... There is absolutely no need for X additional COUNT(*) queries to get reply amount when the reply amount is saved in mybb_threads table as well.

And you can't say "without any problem", big boards would suffer because of that. Your plugin with 15 limit uses more queries on showthread than the whole MyBB core.

(2014-12-11, 08:11 AM)Destroy666 Wrote: [ -> ]

(2014-12-11, 05:00 AM)Harshit Wrote: [ -> ]No, it works completely fine without any problem.

That doesn't mean it's optimised... There is absolutely no need for X additional COUNT(*) queries to get reply amount when the reply amount is saved in mybb_threads table as well.

And you can't say "without any problem", big boards would suffer because of that. Your plugin with 15 limit uses more queries on showthread than the whole MyBB core.

Yup, a left join like

SELECT p.subject, p.tid, p.icon, p.dateline, t.replies FROM mybb_posts p LEFT JOIN mybb_threads t ON (t.tid = p.tid) WHERE p.uid = 1 ORDER BY p.dateline desc LIMIT 10;

would be better.

Also it would leak private sector replies as well due to no forum permission checks.

Now it is OK. It is working fine.