MyBB Community Forums

Full Version: Referrals Are Lost on Account Merge
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
As the title says.

If account A has 6 referrals and is merged into account B with only 1 referral then it will still only say they have 1 referral.

It should carry over IMHO, same with reputation actually.
Confirmed for referrals, but I don't understand this:

(2015-02-17, 03:58 PM)Marisa Wrote: [ -> ]same with reputation actually.

The reputation is already carried over, isn't it?
(2015-02-17, 09:33 PM)Destroy666 Wrote: [ -> ]Confirmed for referrals, but I don't understand this:


(2015-02-17, 03:58 PM)Marisa Wrote: [ -> ]same with reputation actually.

The reputation is already carried over, isn't it?

Certainly not in 1.8.3, unless you just fixed it in 1.8.4...

I merged two accounts a week or so ago and the newly merged user didn't have any reputation points from the old account. Could be a conflict with a plugin on my end but if you say it carries over then I guess I'm wrong.

Although I'm not sure what happens when two accounts get merged that have both recieved reputation from the same user...
Did you do a reputation recount after the merge?
I tested and the reputation is indeed carried over by this code: https://github.com/mybb/mybb/blob/featur....php#L1946

As for multiple reputations by one user - only added reputation seems to be checked for duplicates (and not sure if fully correctly - query results aren't sorted by uids, yet it checks the "neighbours" for duplicates). The received reputation isn't, which is a bug.

This line is fishy too, at least the first part: https://github.com/mybb/mybb/blob/featur....php#L1965 I don't understand why both previous and current reputation are checked in this conditional. Won't this remove invalid reputation and then in the following iteration the next reputation, no matter whether it's valid or not?
I feel like I should bump this thread because I don't believe an issue was opened on Github. Big Grin
Can confirm the referral issue but not the reputation issue.
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2020

Thanks for contributing to MyBB!

Regards,
The MyBB Group