MyBB Community Forums

MyBB Community Forums > Development > MyBB 1.8 Development > 1.8 Bugs and Issues > Pushed > ACP Smilies Mass Editor break all smilies on save.
Full Version: ACP Smilies Mass Editor break all smilies on save.
You're currently viewing a stripped down version of our content. View the full version with proper formatting.

avril

2015-04-07, 01:24 PM
Version : myBB 1.8.4 - clean.
Subject : ACP Smilies Mass Editor break all smilies on save, by changing part of smillies ID's to html entities.

Reproduce bug :
- Go to smilies editor in ACP
- chose mass editing of smilies
- chose save smilies. (no need to edit anything just save)

Causes :
all characters like <> will be changed to html entities which breaks all smilies at once.

Euan T

2015-04-07, 01:52 PM
And that's why you escape HTML entities on output rather than input...

Thanks for the report, I'll test this later.

Destroy666

2015-04-07, 02:12 PM
I can't see how it breaks all smilies, but yea, it breaks smilies with HTML entities due to duplicate htmlspecialchars_uni().

@Euan T, missed your reply earlier, they were not escaped on input, rather twice on output - once in the generate_ functions, which I didn't notice while working on the \ in smilies issue.

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/1953

Thanks for contributing to MyBB!

Regards,
The MyBB Group
MyBB Community Forums > Development > MyBB 1.8 Development > 1.8 Bugs and Issues > Pushed > ACP Smilies Mass Editor break all smilies on save.