2015-06-14, 10:44 AM
Hi everyone!
I'm new to MyBB and this is my first post here, so: nice to meet you all.
I ran across this little glitch while working on a localization of MyBB 1.8.5. I ran a quick search of this forum and didn't find anything that seemed to match it, so I figured I'd better write it up. It's small, and probably easy to fix.
To find the glitch, please navigate to User CP -> Subscribed Threads and look at the icons displayed below the list. The topmost icon on the left reads "New Thread" where it should read "New Posts". (Compare the icons under the thread listing in any forum to see the difference.)
Basically, the label for the icon mentioned in the title seems to be using this string:
Which means I ended up with a translated icon label inviting me to create a new thread.
(EDIT: I originally included references to the "icon_*" strings, but I've since discovered that they're used in the tooltips for the icons in the actual thread list. I still find it puzzling that the tooltips for the icons in the legend simply repeat the labels; perhaps they should be removed?)
I hope this helps.
Cheers,
Dominion
The fix is a change to template "usercp_subscriptions" line 34:
Before:
After:
I'm new to MyBB and this is my first post here, so: nice to meet you all.
I ran across this little glitch while working on a localization of MyBB 1.8.5. I ran a quick search of this forum and didn't find anything that seemed to match it, so I figured I'd better write it up. It's small, and probably easy to fix.
To find the glitch, please navigate to User CP -> Subscribed Threads and look at the icons displayed below the list. The topmost icon on the left reads "New Thread" where it should read "New Posts". (Compare the icons under the thread listing in any forum to see the difference.)
Basically, the label for the icon mentioned in the title seems to be using this string:
- /inc/languages/english/usercp.lang.php => new_thread
- /inc/languages/english/usercp.lang.php => new_posts_thread
Which means I ended up with a translated icon label inviting me to create a new thread.
(EDIT: I originally included references to the "icon_*" strings, but I've since discovered that they're used in the tooltips for the icons in the actual thread list. I still find it puzzling that the tooltips for the icons in the legend simply repeat the labels; perhaps they should be removed?)
I hope this helps.
Cheers,
Dominion
The fix is a change to template "usercp_subscriptions" line 34:
Before:
<dd><span class="thread_status newfolder" title="{$lang->new_thread}"> </span> {$lang->new_thread}</dd>After:
<dd><span class="thread_status newfolder" title="{$lang->new_posts_thread}"> </span> {$lang->new_posts_thread}