MyBB Community Forums

If your headerinclude template has been modified then the upgrade wouldn't apply the change anyway - this is the same for all template updates.

i changed
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1807"></script>

to

<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>

Now, moderation.php is broken...

Sorry, but you did not select any threads to perform inline moderation on, or your previous moderation session has expired (Automatically after 1 hour of inactivity). Please select some threads and try again.

i have ipb theme by eNVy

with 1807 working
with 1809 not working

(2016-12-23, 05:48 PM)AlexanderPep Wrote: [ -> ]i changed
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1807"></script>

to

<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>

Now, moderation.php is broken...

Sorry, but you did not select any threads to perform inline moderation on, or your previous moderation session has expired (Automatically after 1 hour of inactivity). Please select some threads and try again.

i have ipb theme by eNVy

with 1807 working
with 1809 not working

You also need to add

var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";

as shown in https://github.com/mybb/mybb/pull/2468/f...9b667b44b8

We're working on a patch to the release packages.

my headerinclude

<link rel="alternate" type="application/rss+xml" title="{$lang->latest_threads} (RSS 2.0)" href="{$mybb->settings['bburl']}/syndication.php" />
<link rel="alternate" type="application/atom+xml" title="{$lang->latest_threads} (Atom 1.0)" href="{$mybb->settings['bburl']}/syndication.php?type=atom1.0" />

<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/font-awesome/4.6.1/css/font-awesome.min.css">
<link href="http://fonts.googleapis.com/css?family=Hind:400,600" rel="stylesheet">

<meta http-equiv="Content-Type" content="text/html; charset={$charset}" />
<meta http-equiv="Content-Script-Type" content="text/javascript" />
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.plugins.min.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>
<script type="text/javascript" src="{$mybb->asset_url}/images/myipb/custom/Tipsy.js"></script>
<script type="text/javascript" src="{$mybb->asset_url}/images/myipb/custom/jQuery.js"></script>

<script language="javascript" type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/myadvertisements.js"></script>
{$stylesheets}
<script type="text/javascript">
<!--
	lang.unknown_error = "{$lang->unknown_error}";

	lang.select2_match = "{$lang->select2_match}";
	lang.select2_matches = "{$lang->select2_matches}";
	lang.select2_nomatches = "{$lang->select2_nomatches}";
	lang.select2_inputtooshort_single = "{$lang->select2_inputtooshort_single}";
	lang.select2_inputtooshort_plural = "{$lang->select2_inputtooshort_plural}";
	lang.select2_inputtoolong_single = "{$lang->select2_inputtoolong_single}";
	lang.select2_inputtoolong_plural = "{$lang->select2_inputtoolong_plural}";
	lang.select2_selectiontoobig_single = "{$lang->select2_selectiontoobig_single}";
	lang.select2_selectiontoobig_plural = "{$lang->select2_selectiontoobig_plural}";
	lang.select2_loadmore = "{$lang->select2_loadmore}";
	lang.select2_searching = "{$lang->select2_searching}";

	var cookieDomain = "{$mybb->settings['cookiedomain']}";
	var cookiePath = "{$mybb->settings['cookiepath']}";
	var cookiePrefix = "{$mybb->settings['cookieprefix']}";
        var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";
	var deleteevent_confirm = "{$lang->deleteevent_confirm}";
	var removeattach_confirm = "{$lang->removeattach_confirm}";
	var loading_text = '{$lang->ajax_loading}';
	var saving_changes = '{$lang->saving_changes}';
	var use_xmlhttprequest = "{$mybb->settings['use_xmlhttprequest']}";
	var my_post_key = "{$mybb->post_code}";
	var rootpath = "{$mybb->settings['bburl']}";
	var imagepath = "{$theme['imgdir']}";
  	var yes_confirm = "{$lang->yes}";
	var no_confirm = "{$lang->no}";
	var MyBBEditor = null;
	var spinner_image = "{$theme['imgdir']}/spinner.gif";
	var spinner = "<img src='" + spinner_image +"' alt='' />";
	var modal_zindex = 9999;
// -->
</script>{$myalerts_js}

i verify functions.php and general.js and is ok ....
if i put 1807 is ok...with 1809 don't work

(2016-12-23, 06:18 PM)Devilshakerz Wrote: [ -> ]You also need to add

var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";

as shown in https://github.com/mybb/mybb/pull/2468/f...9b667b44b8

We're working on a patch to the release packages.

Unfortunately this doesn't fix the error. You have to remove the quotation marks, since the cookie option "secure" expects a boolean value, not a string:

var cookieSecureFlag = {$mybb->settings['cookiesecureflag']};

Now it's working
Thanks

(2016-12-23, 06:43 PM)doylecc Wrote: [ -> ]

(2016-12-23, 06:18 PM)Devilshakerz Wrote: [ -> ]You also need to add

var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";

as shown in https://github.com/mybb/mybb/pull/2468/f...9b667b44b8

We're working on a patch to the release packages.

Unfortunately this doesn't fix the error. You have to remove the quotation marks, since the cookie option "secure" expects a boolean value, not a string:

var cookieSecureFlag = {$mybb->settings['cookiesecureflag']};

I am little bit confused, so with or without ""?

Will need it without the quotes.

(2016-12-23, 07:42 PM)Matt Wrote: [ -> ]Will need it without the quotes.

Either that or using a more strict comparison: https://github.com/mybb/mybb/pull/2579/c...151cd3d705.

OK, thank you guys.

Will you release only a patch for users who updated to 1.8.9 or will be there full package?