MyBB Community Forums

Full Version: Issues with Inline Moderation? PLEASE READ
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
This issue has been fixed with MyBB 1.8.10: http://blog.mybb.com/2017/01/10/mybb-1-8...e-release/

Hello,

Due to an issue in MyBB 1.8.9, some javascript functionality, such as inline moderation, may malfunction.

If you encounter this issue, please do the following:
  • In your headerinclude template (inside the Ungrouped Templates set), please make sure that the ?ver= attribute has been changed to 1809 in the line:

    <script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1807"></script>
    resulting in:
    <script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>

    Additionally, make sure that after:
    var cookiePrefix = "{$mybb->settings['cookieprefix']}";
    you have this:
    var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";

    Full, patched template contents for MyBB 1.8.9:
    <link rel="alternate" type="application/rss+xml" title="{$lang->latest_threads} (RSS 2.0)" href="{$mybb->settings['bburl']}/syndication.php" />
    <link rel="alternate" type="application/atom+xml" title="{$lang->latest_threads} (Atom 1.0)" href="{$mybb->settings['bburl']}/syndication.php?type=atom1.0" />
    <meta http-equiv="Content-Type" content="text/html; charset={$charset}" />
    <meta http-equiv="Content-Script-Type" content="text/javascript" />
    <script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.js?ver=1806"></script>
    <script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.plugins.min.js?ver=1806"></script>
    <script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1809"></script>
    {$stylesheets}
    <script type="text/javascript">
    <!--
        lang.unknown_error = "{$lang->unknown_error}";
        lang.select2_match = "{$lang->select2_match}";
        lang.select2_matches = "{$lang->select2_matches}";
        lang.select2_nomatches = "{$lang->select2_nomatches}";
        lang.select2_inputtooshort_single = "{$lang->select2_inputtooshort_single}";
        lang.select2_inputtooshort_plural = "{$lang->select2_inputtooshort_plural}";
        lang.select2_inputtoolong_single = "{$lang->select2_inputtoolong_single}";
        lang.select2_inputtoolong_plural = "{$lang->select2_inputtoolong_plural}";
        lang.select2_selectiontoobig_single = "{$lang->select2_selectiontoobig_single}";
        lang.select2_selectiontoobig_plural = "{$lang->select2_selectiontoobig_plural}";
        lang.select2_loadmore = "{$lang->select2_loadmore}";
        lang.select2_searching = "{$lang->select2_searching}";
        var cookieDomain = "{$mybb->settings['cookiedomain']}";
        var cookiePath = "{$mybb->settings['cookiepath']}";
        var cookiePrefix = "{$mybb->settings['cookieprefix']}";
        var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";
        var deleteevent_confirm = "{$lang->deleteevent_confirm}";
        var removeattach_confirm = "{$lang->removeattach_confirm}";
        var loading_text = '{$lang->ajax_loading}';
        var saving_changes = '{$lang->saving_changes}';
        var use_xmlhttprequest = "{$mybb->settings['use_xmlhttprequest']}";
        var my_post_key = "{$mybb->post_code}";
        var rootpath = "{$mybb->settings['bburl']}";
        var imagepath = "{$theme['imgdir']}";
         var yes_confirm = "{$lang->yes}";
        var no_confirm = "{$lang->no}";
        var MyBBEditor = null;
        var spinner_image = "{$theme['imgdir']}/spinner.gif";
        var spinner = "<img src='" + spinner_image +"' alt='' />";
        var modal_zindex = 9999;
    // -->
    </script>

  • In your copy of jscripts/general.js change the line 498:
    secure: cookieSecureFlag,
    to:
    secure: cookieSecureFlag == true,

    Full, patched content of the file: https://raw.githubusercontent.com/mybb/m...general.js

  • In the admin/inc/class_page.php file, change line 111:
    echo " <script type=\"text/javascript\" src=\"../jscripts/general.js?ver=1807\"></script>\n";
    to:
    echo " <script type=\"text/javascript\" src=\"../jscripts/general.js?ver=1809\"></script>\n";

    Additionally, make sure that after line 133:

    var cookiePrefix = '{$mybb->settings['cookieprefix']}';
    you have this:
    var cookieSecureFlag = '{$mybb->settings['cookiesecureflag']}';

    Full, patched content of the file: https://raw.githubusercontent.com/mybb/m...s_page.php


Make sure you then clear your browser cache, otherwise your browser may keep using the older version of the javascript and the issue will persist.

This should resolve the issue. If you are still experiencing problems, please post a thread in the General Support forum.

We apologise for the inconvenience.