MyBB Community Forums

Full Version: Approve/unapprove threads moderator permission broken
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
When adding a moderator, there are two options:
  • Can approve/unapprove threads?
  • Can approve/unapprove posts?
However, enabling the setting to (un)approve threads does not show the option to (un)approve threads on the forum display, instead it checks the posts setting:

if(is_moderator($fid, "canapproveunapproveposts"))
{
	eval("\$inlinemodapproveunapprove = \"".$templates->get("forumdisplay_inlinemoderation_approveunapprove")."\";");
}

So basically, you can only (un)approve threads, if you have the permission to (un)approve posts. The check in forumdisplay.php should check canapproveunapprovethreads instead. The check in showthread.php seems fine.
Can anyone confirm this?
Yep, I can confirm this.
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2592

Thanks for contributing to MyBB!

Regards,
The MyBB Group