MyBB Community Forums

Full Version: Soft Delete Not Working Properly
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
So I've applied the fixes for the Inline Moderation problem to my custom template in MyBB 1.8.10 but I'm still having a minor issue. If you choose the Delete button in the post it soft deletes it like it should, but if you use the check box of the post and then use the Soft Delete option in the Inline Post Moderation drop down it actually does a permanent delete. Any way to resolve this?
What is your forum url and can you provide the headerinclude template to see if it is correct. Have you read carefully through the two sticky threads in the general support thread?
Here is my headerinclude code. Site is forums.fanedit.org. And I did read through the two sticky threads, yes. Thank you.

<link rel="icon" type="image/x-icon" href="https://forums.fanedit.org/images/favicon.ico">
<link rel="alternate" type="application/rss+xml" title="{$lang->latest_threads} (RSS 2.0)" href="{$mybb->settings['bburl']}/syndication.php" />
<link rel="alternate" type="application/atom+xml" title="{$lang->latest_threads} (Atom 1.0)" href="{$mybb->settings['bburl']}/syndication.php?type=atom1.0" />
<meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
<meta http-equiv="Content-Type" content="text/html; charset={$charset}" />
<meta http-equiv="Content-Script-Type" content="text/javascript" />
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/jquery.plugins.min.js?ver=1806"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/general.js?ver=1810"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/responsivemenu.js"></script>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.2.0/css/font-awesome.min.css">
{$stylesheets}<!-- UNREADPOSTS_CSS -->
<!-- start: Full PM --><script>
    var fullpm_language = {
        title: '{$lang->fullpm_title}',
        text: '{$lang->fullpm_text}',
        close: '{$lang->fullpm_close}'
    };
    var showmsg = '{$showmsg}';
    </script><script type="text/javascript" src="{$mybb->asset_url}/jscripts/fullpm.js"></script><!-- end: Full PM -->


<script type="text/javascript" src="{$mybb->asset_url}/jscripts/mylikes.js?ver=101"></script>

<script type="text/javascript">
<!--
	lang.unknown_error = "{$lang->unknown_error}";
	lang.select2_match = "{$lang->select2_match}";
	lang.select2_matches = "{$lang->select2_matches}";
	lang.select2_nomatches = "{$lang->select2_nomatches}";
	lang.select2_inputtooshort_single = "{$lang->select2_inputtooshort_single}";
	lang.select2_inputtooshort_plural = "{$lang->select2_inputtooshort_plural}";
	lang.select2_inputtoolong_single = "{$lang->select2_inputtoolong_single}";
	lang.select2_inputtoolong_plural = "{$lang->select2_inputtoolong_plural}";
	lang.select2_selectiontoobig_single = "{$lang->select2_selectiontoobig_single}";
	lang.select2_selectiontoobig_plural = "{$lang->select2_selectiontoobig_plural}";
	lang.select2_loadmore = "{$lang->select2_loadmore}";
	lang.select2_searching = "{$lang->select2_searching}";
	var cookieDomain = "{$mybb->settings['cookiedomain']}";
	var cookiePath = "{$mybb->settings['cookiepath']}";
	var cookiePrefix = "{$mybb->settings['cookieprefix']}";
	var cookieSecureFlag = "{$mybb->settings['cookiesecureflag']}";
	var deleteevent_confirm = "{$lang->deleteevent_confirm}";
	var removeattach_confirm = "{$lang->removeattach_confirm}";
	var loading_text = '{$lang->ajax_loading}';
	var saving_changes = '{$lang->saving_changes}';
	var use_xmlhttprequest = "{$mybb->settings['use_xmlhttprequest']}";
	var my_post_key = "{$mybb->post_code}";
	var rootpath = "{$mybb->settings['bburl']}";
	var imagepath = "{$theme['imgdir']}";
  	var yes_confirm = "{$lang->yes}";
	var no_confirm = "{$lang->no}";
	var MyBBEditor = null;
	var spinner_image = "{$theme['imgdir']}/spinner.gif";
	var spinner = "<img src='" + spinner_image +"' alt='' />";
// -->
</script>{$myalerts_js}
The template is correct by observing the main dilemmas MyBB has been experiencing. I think you should do the following:

1. When did the soft delete problem start? Have you installed a new plugin that might cause a conflict?

2. Have you tested all the moderation tools to make sure they all work correctly?

3. This does not involve the issue, but it is always nice to update your font awesome to 4.7.0 (the latest version)
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.2.0/css/font-awesome.min.css">
to
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css">
Thank you for taking a look. It was only just reported to me by one of my moderators. I know it was working fine under 1.8.8. It wasn't reported during the short time I had 1.8.9 installed, so it was either with that version or 1.8.10. And no... no new plugins.

I tested the other moderation tools and they all seem to work, it's just soft delete. I also tested it with the default MyBB style and the problem is there too.

Is it possible there is other code in another template that could be causing the problem?
Alright, I got the inline moderation error soft deleting a thread without it being ticked:

[Image: 4aadf7fb7d8f4207825c4e08c930480d.png]

The moderator could have tried soft deleting a thread by inline post moderation instead of using moderation options to delete a thread. However, it works correctly after ticking the box to the post to select it for moderation.

Sorry, it is really frustrating and I feel you deeply. The MyBB staff mainly works with the default theme and help users with 3rd party themes the best to their ability. Mostly, theme authors do come out and provide support with their well knowledge of the design. 

For troubleshooting myself to see if it could me a minor mistake on using the tools could be a problem as we all make mistakes. The tools should work

[Image: cxTat8J.png] general.js is up to date with 1.8.10
[Image: cxTat8J.png] you have the cookiesecureflag in the correct place.
[Image: cxTat8J.png] headerinclude looks correct.

I really hope a staff member can give you a hand. We both can troubleshoot this all day and generate new issues together lol.
Thank you for confirming it's not just me, however I'm not sure if we're experiencing the same problem or similar ones. Say there is a post I want to delete, I tick the box of the post and then select Soft Delete Posts from the Inline Post Moderation (such as you have shown). The post permanently deletes instead of just a soft deletion. Is this how it worked for you too?
Oh!

Do you mean when you soft delete a thread everything disappears, but shows on the thread listing? That does happen for me and can be restored by the moderation option: Restore thread. It seems like it is deleted.

[Image: a035adb909d646aca1f4b5e44f442042.png]

[Image: 788a5b50d7e44f57800a37e2716d8832.png]

[Image: e1eaa95f57804790bb2f0faa956db097.png]

[Image: ed088ef0a0f74beda3f8df8ef7a22e0d.png]

If this is not similar, and what you are saying that using the soft delete deletes it permanently may be a malfunction or conflict. Also, it makes your issue much clearer as I thought the soft delete does not work at all. You may have to wait until a staff member could help you as I am not much experience is the moderation coding. I really hope the screenshots are the same.
No... soft deleting threads seems to work fine. It's just when soft deleting a post. Soft deleting a post results it in being permanently deleted. It's not shown as soft deleted and it cannot be restored.

EDIT: I've added a video to help illustrate what I mean. You soft delete a post within a thread and then when you go to where the post should be it's completely gone and not available to be restored.

Alright so instead of soft deleting it permanently deletes post instead. Do you remember the last administrative action you made before a moderator appointed the issue? Basically retracing your steps. I will leave someone more experience to give you a hand. I tried to help you the best I can. I hope my aid, helps clarify the dilemma. Best of luck! Smile
Pages: 1 2