MyBB Community Forums

Full Version: Show Thread Internal Interal Error
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
[Image: JwZxvf7.png]
Are mybb forums limited in the amount of threads?
URL: https://community.mybb.com/showthread.ph...n=lastpost
[Image: nzp8RG0.png]
Are mybb forums limited in the amount of forums?
URL: https://community.mybb.com/forumdisplay....4294967296
This is due to the length of the column in the database. I can't remember what the length is set to, but there should be checks done before the query is executed to make sure we aren't trying to insert values out of range.
Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2853

Thanks for contributing to MyBB!

Regards,
The MyBB Group
I've merged two of your threads together that are the same class of issue, as it would make sense to track them together at the same time in my opinion.
The sessions table location1 and location2 fields are unsigned ints, so the maximum value is 4294967295. A check is probably the best thing to do.
(2017-10-01, 10:43 PM)Starpaul20 Wrote: [ -> ]The sessions table location1 and location2 fields are unsigned ints, so the maximum value is 4294967295. A check is probably the best thing to do.

Change to big ints?
@StarPaul20 - can you please make a PR?
(2017-10-01, 11:43 PM)Lunorian Wrote: [ -> ]
(2017-10-01, 10:43 PM)Starpaul20 Wrote: [ -> ]The sessions table location1 and location2 fields are unsigned ints, so the maximum value is 4294967295. A check is probably the best thing to do.

Change to big ints?

Not worth it to be honest (just how many sites are gonna have nearly 4.3 billion threads? Gaia Online doesn't even have half that) plus it would needlessly increase the database size (an int column needs 4 bytes per record while a bigint needs 8 bytes per record. Multiply that by the number of records in even a small board's posts and threads table it starts to add up. Not to mention the same issue would still exist since an unsigned bigint still has a max size (just much higher, around 18.4 quintillion).

(2017-10-02, 04:05 PM)Eldenroot Wrote: [ -> ]@StarPaul20 - can you please make a PR?

Might do that, need to discuss with the other Devs first.
[Image: Screen%20Shot%202017-10-02%20at%206.59.04%20PM.png]
Discloses the database prefix too ^^^