2018-05-30, 11:20 PM
A personal pet hate of mine and i am sure others is that some images such as the collapse images are hard coded into the core and as such require either a core modification or to change the way those images are used within the templates or the system via plugins etc.
An example being;
in the functions_forumlist.php
note here that to use svg images with the default expander var you need to edit the above as shown for this to work.
it would be nice to see this made a variable within a template or setting.
I know there are other ways to achieve this but for the average user or themer it would be nicer to have greater control over images than to have to add more code or have to rely on a png in todays designs.
Just my opinion but a bit of a pain from my view.
An example being;
in the functions_forumlist.php
// Check if this category is either expanded or collapsed and hide it as necessary.
$expdisplay = '';
$collapsed_name = "cat_{$forum['fid']}_c";
if(isset($collapsed[$collapsed_name]) && $collapsed[$collapsed_name] == "display: show;")
{
//$expcolimage = "collapse_collapsed.png"; Removed to allow for svg images
$expcolimage = "collapse_collapsed.svg";
$expdisplay = "display: none;";
$expthead = " thead_collapsed";
$expaltext = "[+]";
}
else
{
// $expcolimage = "collapse.png"; Removed to allow for svg images
$expcolimage = "collapse.svg";
$expthead = "";
$expaltext = "[-]";
}
note here that to use svg images with the default expander var you need to edit the above as shown for this to work.
it would be nice to see this made a variable within a template or setting.
I know there are other ways to achieve this but for the average user or themer it would be nicer to have greater control over images than to have to add more code or have to rely on a png in todays designs.
Just my opinion but a bit of a pain from my view.