MyBB Community Forums

Full Version: Double Comma in Users Online Stats
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
https://universalgaming.net/index.php

The users online area in the Board Statistics shows a double comma after each member username. I've been trying to figure out where to find the cause of the problem but haven't been having much luck so far.  Huh
What version of MyBB are you using? The latest version 1.8.17 fixes this.
I'm using 1.8.17. Should I re-upload the files for it to my server?
Download the latest package and replace your index.php & portal.php with the latest.
Alternately you can crosscheck if the changes in this PR are present in your files or not to be sure:
https://github.com/mybb/mybb/pull/3300/files
I downloaded 1.8.17 and replaced those two files but it hasn't seemed to fix it. Sad
I'm also having this problem. I found that if you removed {$comma} from this in index_whosonline_memberbit:
{$comma}{$user['profilelink']}{$invisiblemark}
...it will show normally, but the plugin Show the users that has been online today by CraKteR (edited by Sinatra) will have the usernames stacked.

https://japanesemetalforum.com/index.php
This is strange. Though the '{$comma}' is unnecessary in the templates as it is handled within script only but while rendering memberbit template the value of '{$comma}' should always be empty having no impact to the final output. Even if the value of '{$comma}' is already set somewhere else the same should be reset before rendering the memberbit template.

I will remove the unnecessary variable from template. Thanks for pointing out.
I re-uploaded the 1.8.17 files to my server but the issue still persists. I also have a problem with the login screen doing this:

Authorization code mismatch. Are you accessing this function correctly? Please go back and try again.
Edit: Found the fix from a 1.8.16 thread after being told it was a bug from that version.
(2018-07-20, 02:56 PM)effone Wrote: [ -> ]This is strange. Though the '{$comma}' is unnecessary in the templates as it is handled within script only but while rendering memberbit template the value of '{$comma}' should always be empty having no impact to the final output. Even if the value of '{$comma}' is already set somewhere else the same should be reset before rendering the memberbit template.

I will remove the unnecessary variable from template. Thanks for pointing out.
I will remove it from my copy, as well. Where can I look further into fixing these double commas?
(2018-07-21, 02:51 AM)rfssjz Wrote: [ -> ]I will remove it from my copy, as well. Where can I look further into fixing these double commas?

Most likely it will be removed in next release.
https://github.com/mybb/mybb/issues/3349