2018-12-26, 08:20 AM
First, the bugs:
Forum selection is lost on URL regeneration:
Reproduction steps:
1. Select some forums and generate the URL. The url contains fids. OK.
2. In the returned page don't touch forum selection, change the feed version and / or limit, or even do nothing at all, regenerate the url. fids are now lost in feed url.
Reason is, if you look minutely returned page has the first "Syndicate all Forums" field selected by default, no matter you selected that previously or not and that overrules the other selections.
Accessible Forums Permission:
You can generate feeds from restricted forums if you have access to those. I am not sure why this is designed this way, but IMO feed should be allowed for only forums visible to guests since in most case this is gonna dealt by third party feed readers. Allowing that may disclose posts from secret forums. Opinions appreciated.
Hardcoded minimum limit - contradicting:
The minimum limit of the syndication is set to 15 by 'misc.php' (which generates the page) and 20 by 'syndication.php' (which generates the feed). This should be driven by user settings, or at-least same in both places.
Cluttered code:
Not a big issue, but the code in page generator introduced unnecessary variables and condition loops, which in 15 minutes of effort I have cut down to 50% (not going into deep now, curious heads can ask further).
Implement JSON Feed output format:
As stated,
This will be a great addition to MyBB Syndication.
Include author details:
Currently no author details are included in feeds. All standards allow to include details (author name, uid and / or avatar) of author per
Implementation of
Well, now this is a little much at this moment, I know, but to keep in mind for future. Modern readers have option not to fetch the feeds in certain interval and compare / replace with the old. Feed holds a top level array pointer that can send notification to the subscribers on feed change to fetch and refresh.
Forum selection is lost on URL regeneration:
Reproduction steps:
1. Select some forums and generate the URL. The url contains fids. OK.
2. In the returned page don't touch forum selection, change the feed version and / or limit, or even do nothing at all, regenerate the url. fids are now lost in feed url.
Reason is, if you look minutely returned page has the first "Syndicate all Forums" field selected by default, no matter you selected that previously or not and that overrules the other selections.
Accessible Forums Permission:
You can generate feeds from restricted forums if you have access to those. I am not sure why this is designed this way, but IMO feed should be allowed for only forums visible to guests since in most case this is gonna dealt by third party feed readers. Allowing that may disclose posts from secret forums. Opinions appreciated.
Hardcoded minimum limit - contradicting:
The minimum limit of the syndication is set to 15 by 'misc.php' (which generates the page) and 20 by 'syndication.php' (which generates the feed). This should be driven by user settings, or at-least same in both places.
Cluttered code:
Not a big issue, but the code in page generator introduced unnecessary variables and condition loops, which in 15 minutes of effort I have cut down to 50% (not going into deep now, curious heads can ask further).
Implement JSON Feed output format:
As stated,
- This format is being popular. Many popular sites use this format, including Yahoo Weather and what not. Wordpress also has a plugin in place https://wordpress.org/plugins/jsonfeed/
- Since Google has dropped feed API in 2016 its now not possible to get cross-domain feeds without readers, say, using simple jQuery. Earlier it was possible using Google API as proxy.
- Easy to handle the data.
- There is already a standard in place since 2017. https://jsonfeed.org/version/1
This will be a great addition to MyBB Syndication.
Include author details:
Currently no author details are included in feeds. All standards allow to include details (author name, uid and / or avatar) of author per
item. Even MyBB Syndication class already supports inclusion of author but MyBB generator has no clue about this. This is useful and should be included.Implementation of
hubs (?):Well, now this is a little much at this moment, I know, but to keep in mind for future. Modern readers have option not to fetch the feeds in certain interval and compare / replace with the old. Feed holds a top level array pointer that can send notification to the subscribers on feed change to fetch and refresh.