MyBB Community Forums

Full Version: Header no longer displays red alert join requests to groupleaders
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
In global.php the usergroups cache is checked for 'joinable' which doesn't exist.
https://github.com/mybb/mybb/blob/featur...#L633-L637

If a group is joinable and needs moderation the type is set to 4 in the cache:
https://github.com/mybb/mybb/blob/featur...#L840-L845


E.g. by checking the group's cache for 'type' 4 instead of 'joinable' in global.php the message is displayed in the header:
if(!empty($groupscache[$user['gid']]['type']) && $groupscache[$user['gid']]['type'] == 4)
{
    $showjoinnotice = true;
    $gids .= ",'{$user['gid']}'";
}
Oh, I get it.

There's no such problem in v1.9, but I have checked the code in v1.8 it does exist.
Beautiful! Changing those values in global.php fixed it. Glad to have that functionality back -- Thank you!
@doylecc I would be grateful if you were willing to submit that as a PR if you haven't already?
Pages: 1 2