MyBB Community Forums

There are several users having issues with upgrading from MyBB 1.6 or 1.8.6 (e.g. https://community.mybb.com/thread-225193.html, https://community.mybb.com/thread-225358.html or https://community.mybb.com/thread-214042.html).

This issue was introduced with this commit: https://github.com/mybb/mybb/commit/0315...52bc18c047

document.forms[0].submit();

was replaced with

document.forms[0].trigger('submit');

Apparently the developer though this code needed to be updated to work with current jQuery versions. However it doesn't use jQuery at all and is broken now.

btw: Links seem to be parsed incorrectly.

Offtopic - there is something wrong with URL parsing in posts?

(2019-12-04, 08:32 PM)Eldenroot Wrote: [ -> ]Offtopic - there is something wrong with URL parsing in posts?

Yes, https://github.com/mybb/mybb/pull/3821 will need to be corrected for 1.8.22.

Is there a chance to get the upgrade bug fixed in 1.8.22? It's simple to fix and apparently some users are still upgrading from very old versions.

Would be nice to see you again back in MyBB team or at least a contributor

https://github.com/mybb/mybb/pull/3842 will need a review/LGTM, otherwise it will be deferred.

Reviewing shouldn't be too difficult given the same code worked for years.