Pretty interesting plugin martec, what was the motivation behind thie Extra poll?
(2020-12-08, 01:49 PM)WallBB Wrote: [ -> ]Pretty interesting plugin martec, what was the motivation behind thie Extra poll?
this for my production forum...
It was something that my users always asked for.
I'm just sharing the plugin.
(2020-12-08, 01:57 PM)martec Wrote: [ -> ] (2020-12-08, 01:49 PM)WallBB Wrote: [ -> ]Pretty interesting plugin martec, what was the motivation behind thie Extra poll?
this for my production forum...
It was something that my users always asked for.
I'm just sharing the plugin.
Awesome, thanks for the plugin
Hi, thank you for your contribution.
I'm a little confused by the decision to use the cache system for this plugin, as well as the exact working of the following piece of code (a per page feature is added but you overwrite the cache on every run, which seems confusing to me):
https://github.com/martec/Extra_Poll/blo...#L606-L614
Maybe dropping the cache altogether and simply adding a new column to the threads table to mark for extra polls, this might also drop the dependency on the core poll for displaying extra polls.
0.1.3 Released
Change log:
https://community.mybb.com/mods.php?acti...g&pid=1410
(2020-12-09, 01:15 AM)Omar G. Wrote: [ -> ]Hi, thank you for your contribution.
I'm a little confused by the decision to use the cache system for this plugin, as well as the exact working of the following piece of code (a per page feature is added but you overwrite the cache on every run, which seems confusing to me):
https://github.com/martec/Extra_Poll/blo...#L606-L614
very thanks for information.
i added the condition (https://github.com/martec/Extra_Poll/blo...l.php#L610) to check if rebuid is finished before update cache to avoid unnecessary query. Again thanks for information.
(2020-12-09, 01:15 AM)Omar G. Wrote: [ -> ]Maybe dropping the cache altogether and simply adding a new column to the threads table to mark for extra polls, this might also drop the dependency on the core poll for displaying extra polls.
Yes, you are absolutely right. But unfortunately I have no plans to do this level of change, maybe in the future or feel free to send PR or create a fork of this plugin.
0.2.0 Released
Change log:
https://community.mybb.com/mods.php?acti...g&pid=1410
Update:
Unistall old version, upload new version and install.
(2020-12-09, 01:15 AM)Omar G. Wrote: [ -> ]Maybe dropping the cache altogether and simply adding a new column to the threads table to mark for extra polls, this might also drop the dependency on the core poll for displaying extra polls.
Done in 0.2.0
0.2.5 Released
Change log:
https://community.mybb.com/mods.php?acti...g&pid=1410
This plugin uses the mybb code as a base. If there is vulnerability in the base code this plugin is also affected.
Medium risk: Poll vote count SQL injection (
advisory) — reported by Devilshakerz (MyBB Team)
How update:
0.2.0 or above, only replace files
below than 0.2.0 Unistall old version, upload new version and install .