Hi, thank you for your contribution
As a suggestion, consider using the
is_member()
core function. Like so:
$allowed = is_member($mybb->settings['PrefixFilter_groups']);
Please also add "title tag" on mouse hover over the prefix. It should display the name of the prefix.
Also templates are not cached... "PrefixFilter"!
(2021-02-08, 11:43 PM)OmarĀ G. Wrote: [ -> ]Hi, thank you for your contribution
As a suggestion, consider using the is_member()
core function. Like so:
$allowed = is_member($mybb->settings['PrefixFilter_groups']);
Thanks, I was not familiar with this function
(2021-02-09, 07:18 PM)Eldenroot Wrote: [ -> ]Please also add "title tag" on mouse hover over the prefix. It should display the name of the prefix.
Also templates are not cached... "PrefixFilter"!
ok
Unfortunately your plugin adds one extra query for one thread prefix. It means about 3-5 ms for each prefix... in my case about +60 queries and +300 ms loading time on index.
https://github.com/zingaburga/XThreads-M...-804865137
You should use better optimisation for queries. Anyway your plugin si really useful and would be great if we could get new release with a fix
Thank you in advance!
Yes, also no template caching is used
I hope that we will get new version soon... until then I will apply your code, thank you!
Be patient guys, implementing enhancements also relies on available time.
Mostafa is an excellent developer. I highly reccomend getting private work done by him as well.
Thanks for the release again
Thank you Mostafa.Shiraali for updating it. Thanks Laid & Eldenroot