MyBB Community Forums

Full Version: Hook misplacement in Calendar.php
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
I'm pretty new to developing plugins, and I've noticed what I think is a minor bug, sorry if it's supposed to be like that.
The line in the calendar.php

$plugins->run_hooks("calendar_event_end");

under the day_view action I think should be put right before the line
eval("\$events .= \"".$templates->get("calendar_dayview_event")."\";");

So that it fires after creating each event for the day instead of after the loop so it only fires once after all events have been created. The reason I suggest this change is because the plugin i'm working on basically adds a button for a signup sheet tied to each event. It was working with the single event view but not the day view until I made this change. I'm not sure if anyone might need it but you can add a dayview_end hook after the loop to fire after all the events have been created for the day also.

Thanks