MyBB Community Forums

Is there a template edit I need to do in order for it to show up in the UCP?

usercp_nav_misc
Find...

<tr><td class="trow1 smalltext">{$draftstart}<a href="usercp.php?action=drafts" class="usercp_nav_item usercp_nav_drafts">{$lang->ucp_nav_drafts} {$draftcount}</a>{$draftend}</td></tr>

Add After...

<tr><td class="trow1 smalltext"><a href="usercp.php?action=favorites" class="usercp_nav_item usercp_nav_favorites">{$lang->ucp_nav_favorite_threads}</a></td></tr>

So I can't tell... =/ I don't want to waste time downloading this. Does this work? Or would I have to make changes?

Thank you.
But isn't it supposed to say My Favorite Posts?
It says Favorite Threads instead.

Also, the link directs to a blank white page.

(2010-04-03, 12:26 AM)SSBBRAWLIN Wrote: [ -> ]Thank you.
But isn't it supposed to say My Favorite Posts?
It says Favorite Threads instead.

Also, the link directs to a blank white page.

Strange...it works perfectly fine on my forum.
It's actually Favorite threads...not posts.

Thank you for the help, X.
But I think you're confused with what I'm asking help with.

The template code that you provided for me was for the "Favorite Threads" plugin.
http://mods.mybboard.net/view/favorite-threads

The one I'm asking help for is the "Favorite Post" plugin.
http://mods.mybboard.net/view/my-favourite-posts

It works fine when I activate it, but the option in the UCP doesn't appear.
So the people at my site can't view the posts that they marked.

Hi,

This plugin outputs an error when it is used under MyBB 1.6

This is the error message outputted:

SQL Error:
    1146 - Table 'test.m_posts' doesn't exist
Query:
    SELECT f.*, p.subject FROM mybb_my_fav_post f RIGHT JOIN m_posts p ON f.pid = p.pid AND f.uid = 1 WHERE p.pid = 1 

I've looked on topic #8 to see if any changes were required but it just seems that m_posts is no longer available.

If anyone knows where to correct this detail I'd be appreciated.

First, nice work.

Second, my suggestions

Do not use:

$db->delete_query('templates', "`title` = '{$template_array[$i]}'");

Inside a loop to delete the templates.
Use a single query to delete multiple templates:

$db->delete_query('templates', "`title` IN ('template1','template2','template3')");

There is a security issue here:

$pid = $mybb->input['pid'];

Even though 'pid' is escaped by MyBB when the MyBB class is inited, you should not rely on that because you do not know if MyBB or any plugin (for some reason) assigns $mybb->input['pid'] to another value which may not be escaped.

You should always be sure that the data you use is escaped, no matter if it has been escaped already (unless we're talking about string escaping).

Use:

$pid = (int)$mybb->input['pid'];

Everything else seems okay to me, great work and idea

Good suggestions. I'm actually using this plugin to learn more about their coding as well.

Would you care to see what need to be fixed to work on myBB 1.6?

What is the equivalent of m_posts for the new version as reported here: http://community.mybb.com/thread-59022-p...#pid554785

Any ideas?

btw: I'm a big fan of your marketplace plugin. Very powerful.

(2010-08-12, 08:47 PM)nunobrito Wrote: [ -> ]Good suggestions. I'm actually using this plugin to learn more about their coding as well.

Would you care to see what need to be fixed to work on myBB 1.6?

What is the equivalent of m_posts for the new version as reported here: http://community.mybb.com/thread-59022-p...#pid554785

Any ideas?

btw: I'm a big fan of your marketplace plugin. Very powerful.

That's something that should be up to the developer to fix. I don't have the time to look at it and debug the problem, sorry.