MyBB Community Forums

MyBB Community Forums > Community Archive > Archived Forums > Archived Development and Support > MyBB 1.6 > 1.6 Suggestions and Feedback > A little question about some code...
Full Version: A little question about some code...
You're currently viewing a stripped down version of our content. View the full version with proper formatting.

WDZ

2006-01-13, 06:07 AM

Chris Boulton

2006-01-13, 07:01 AM
Well, the eror checking could be performed earlier. I guess that is just how it was written when it first was.

I'll change that - it'll save some querying for invalid posts.

WDZ

2006-01-13, 02:53 PM
Chris Boulton Wrote:I guess that is just how it was written when it first was.
Hmm... yeah, you're right, I just checked the original RC2 code and the same problem existed, but there just weren't as many lines separating the query and the check. =/

Quote:I'll change that - it'll save some querying for invalid posts.
Cool. [Image: mininana.gif] Check out newreply and newthread as well... although the problem isn't as bad there, I still think it makes more sense to check the result of the query ASAP. Toungue

WDZ

2006-01-13, 03:13 PM

decswxaqz

2006-01-13, 05:14 PM
Since we are on the topic of optimising code. How about a reply to this?
MyBB Community Forums > Community Archive > Archived Forums > Archived Development and Support > MyBB 1.6 > 1.6 Suggestions and Feedback > A little question about some code...