MyBB Community Forums

Hi everybody!

During translation work I found that in akismet.lang.php file variable 'redirect_return_forum' defined twice with different content. Also in akismet.php it used twice with different context.

May I suggest attached patch to fix this inconsistency ?

thanks.

P.S. I don't use this plugin, but nevertheless

---

hmm.
there is a lot's of duplicates inside language files. I wrote a special tool to find them.
I didn't look on duplicates between files yet, but duplicates inside files definitely make no sense.

here is a report from my tool:

admin files:

admin/config_banning.lang.php:'ban_ip_address' defined 2 times
        value 1:"Ban an IP Address"
        value 2:"Ban IP Address"
admin/config_languages.lang.php:'edit_properties' defined 2 times
        value 1:"Edit Properties"
        value 2:"Edit Language Pack Properties"
admin/config_settings.lang.php:'edit_setting_group' defined 2 times
        value 1:"Edit Setting Group"
        value 2:"Edit Setting Group"
admin/forum_management.lang.php:'add_child_forum' defined 2 times
        value 1:"Add Child Forum"
        value 2:"Add Child Forum"
admin/forum_management.lang.php:'edit_forum' defined 2 times
        value 1:"Edit Forum"
        value 2:"Edit Forum"
admin/forum_management.lang.php:'forum' defined 2 times
        value 1:"Forum"
        value 2:"Forum"
admin/global.lang.php:'go' defined 2 times
        value 1:"Go"
        value 2:"Go"
admin/style_themes.lang.php:'export_theme' defined 2 times
        value 1:"Export Theme"
        value 2:"Export Theme"
admin/tools_adminlog.lang.php:'admin_log_config_settings_delete_duplicates' defined 2 times
        value 1:"Deleted duplicate settings and setting groups"
        value 2:"Deleted any found duplicate settings."
admin/tools_maillogs.lang.php:'from' defined 2 times
        value 1:"From"
        value 2:"From"
admin/tools_modlog.lang.php:'date' defined 2 times
        value 1:"Date"
        value 2:"Date"
admin/tools_modlog.lang.php:'forum' defined 2 times
        value 1:"Forum:"
        value 2:"Forum:"
admin/tools_modlog.lang.php:'username' defined 2 times
        value 1:"Username"
        value 2:"Username"
admin/user_group_promotions.lang.php:'edit_promotion' defined 2 times
        value 1:"Edit Promotion"
        value 2:"Edit Promotion"
admin/user_group_promotions.lang.php:'post_count' defined 2 times
        value 1:"Post Count"
        value 2:"Post Count"
admin/user_group_promotions.lang.php:'time_registered' defined 2 times
        value 1:"Time Registered"
        value 2:"Time Registered"
admin/user_groups.lang.php:'group_leaders' defined 2 times
        value 1:"Group Leaders"
        value 2:"Group Leaders"
admin/user_mass_mail.lang.php:'delivery_date' defined 2 times
        value 1:"Delivery Date"
        value 2:"Delivery Date"
admin/user_mass_mail.lang.php:'subject' defined 3 times
        value 1:"Subject"
        value 2:"Subject"
        value 3:"Subject"
admin/user_users.lang.php:'last_known_ip' defined 2 times
        value 1:"Last Known IP"
        value 2:"Last known IP address matches"

usual files:

akismet.lang.php:'redirect_return_forum' defined 2 times
        value 1:"You may return to the forum <a href=\"{1}\">here</a>."
        value 2:"You may return to the thread <a href=\"{1}\">here</a>.<br />Alternatively, return to the <a href=\"{2}\">forum.</a>"
calendar.lang.php:'repeats_every' defined 2 times
        value 1:"Repeats every"
        value 2:"Repeats every"
memberlist.lang.php:'advanced_search' defined 2 times
        value 1:"Advanced Search"
        value 2:"Advanced Search"
modcp.lang.php:'subject' defined 2 times
        value 1:"Subject"
        value 2:"Subject"
modcp.lang.php:'thread' defined 2 times
        value 1:"Thread"
        value 2:"Thread:"
modcp.lang.php:'title' defined 2 times
        value 1:"User Title:"
        value 2:"Title"
modcp.lang.php:'usergroup' defined 2 times
        value 1:"User Group:"
        value 2:"Primary Group"
modcp.lang.php:'username' defined 2 times
        value 1:"Username"
        value 2:"Username"
moderation.lang.php:'merge_threads' defined 2 times
        value 1:"Merge Threads"
        value 2:"Merge Threads"
moderation.lang.php:'thread' defined 2 times
        value 1:"Thread:"
        value 2:"Thread:"
private.lang.php:'compose_message' defined 2 times
        value 1:"Compose Message"
        value 2:"Message:"
usercp.lang.php:'edit_lists' defined 2 times
        value 1:"Edit Buddy and Ignore Lists"
        value 2:"Edit Buddy and Ignore Lists"
usercp.lang.php:'forum' defined 2 times
        value 1:"Forum"
        value 2:"Forum"
usercp.lang.php:'thread' defined 2 times
        value 1:"Thread"
        value 2:"Thread"
usercp.lang.php:'unsubscribe' defined 2 times
        value 1:"Unsubscribe"
        value 2:"Unsubscribe"
usercp.lang.php:'usergroup' defined 2 times
        value 1:"User Group:"
        value 2:"Usergroup"
warnings.lang.php:'reason' defined 2 times
        value 1:"Reason:"
        value 2:"Reason:"
warnings.lang.php:'warn_user_desc' defined 2 times
        value 1:""
        value 2:"Here you can increase the warning level of this user if they've violated one or more rules."

off course I can simply remove full duplicates, but what if they used in different context with different meaning? Translation can depend on it.

Can you please spend some time to clean up these things ?

I can do some things which are clear for me, but I'm not a guru in all MyBB insides.

akismet.lang.php clean up already proposed in previous post.

P.S. posts merging in this case looks funny

---

this topic remind me a very old russian joke:

Quote:a man come into a psychiatrist's office and says: doctor, I have a problem, I'm ignored by everyone. Doctor: next please.

A lack of a reply doesn't mean a lack of attention