(2010-10-22, 06:58 PM)labrocca Wrote: [ -> ] (2010-10-22, 06:23 PM)adbrad Wrote: [ -> ] (2010-10-22, 06:12 PM)Firestryke31 Wrote: [ -> ]First, a template for the links:
<li><a href="{$link}"><img src="{$theme['imgdir']}/toplinks/{$img}" alt="" title="" />{$title}</a></li>
This allows per-theme customizations to all of the links at once without breaking plugin deactivate/uninstall.
These are already in the header template and can be changed on a per theme basis.
Yeah exactly. How do you think it is now?
The way I was thinking was that it would be built dynamically instead of having plugins modify the template. Right now if I changed the menu away from a <ul> it would break basically every plugin that adds a top link. By building the toplinks dynamically using a template I can easily, say, add endcaps to each button.
I suggest for 2.0 new style theme and cms integrated
(2010-10-23, 02:16 AM)Firestryke31 Wrote: [ -> ] (2010-10-22, 06:58 PM)labrocca Wrote: [ -> ] (2010-10-22, 06:23 PM)adbrad Wrote: [ -> ] (2010-10-22, 06:12 PM)Firestryke31 Wrote: [ -> ]First, a template for the links:
<li><a href="{$link}"><img src="{$theme['imgdir']}/toplinks/{$img}" alt="" title="" />{$title}</a></li>
This allows per-theme customizations to all of the links at once without breaking plugin deactivate/uninstall.
These are already in the header template and can be changed on a per theme basis.
Yeah exactly. How do you think it is now?
The way I was thinking was that it would be built dynamically instead of having plugins modify the template. Right now if I changed the menu away from a <ul> it would break basically every plugin that adds a top link. By building the toplinks dynamically using a template I can easily, say, add endcaps to each button.
Surely you could do that yourself by making a custom template.
(2010-10-23, 09:18 PM)caygri Wrote: [ -> ]I suggest for 2.0 new style theme and cms integrated
I believe there is a new default theme being released when 2.0 is released.
really is fantastic! more or less when is ready 2.0?
Not for a long time they've only just released 1.6
I doubt a CMS is planned though. I could see a page manager, but thats even bloatish.
I think they'll probably keep page manager as a plugin.
(2010-10-23, 09:27 PM)adbrad Wrote: [ -> ]Surely you could do that yourself by making a custom template.
But other plugins wouldn't use that template, I'd still have to modify the header template with the plugins, and there's still no hook allowing me to populate the toplinks dynamically. It should be where if you want to add something to the toplinks, you just append to an array or something in a hook. Right now if the user modifies the code you add to a template they risk breaking the deactivate/uninstall procedure because the template no longer contains what the plugin expects. With my way, all a plugin has to do to stop displaying a toplink is stop hooking itself into the list of links to display.
What about compression of all JS/CSS files? It saves a few hundred kilobytes of storage, and would be beneficial for scalability.