MyBB Community Forums

Full Version: Archive smilies dont work after upgrade to 1.6.1
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
I noticed in my awstats that there was lots of 404 (Not Found) log entries.

This start to happen when i upgraded my forum from 1.6.0 to 1.6.1. Smielies are working fine in normal mode but archive mode loos smilies.

Is this a bug or did something went wrong when upgrading?

Edit: Test smilie Sad

You can test that smielies dont work here either
You can see this on archive;
Quote:You're currently viewing a stripped down version of our content. View the full version with proper formatting.

Means you've to "View this in Full Version" for "Proper" formatting.
(2010-12-29, 10:12 AM)Yaldaram Wrote: [ -> ]You can see this on archive;
Quote:You're currently viewing a stripped down version of our content. View the full version with proper formatting.

Means you've to "View this in Full Version" for "Proper" formatting.

Yes i understand that.

I think it's not proper way to display smilies in archive when they show up as 404 image not found.
I believe you may have found a bug. I'm looking in to what might be causing this right now and will update

Smilies were showing in 1.6.0 in archive as they should. If smilies are not supposed to be shown then the smilie should not be parsed and hence not cause 404 errors.
Ok, found whats causing this. I'll report to this as a bug on the dev site, and will let them take care of it. Hopefully it should be fixed in 1.6.2
Can you please point out the issue either in file G33K, so I might fix it myself on 1.6.1 of my forum ?
(2010-12-29, 10:53 AM)Yaldaram Wrote: [ -> ]Can you please point out the issue either in file G33K, so I might fix it myself on 1.6.1 of my forum ?

I've outlined it here:
http://dev.mybb.com/issues/1392

For a quick fix you can replace line 402 of ./inc/class_parser.php with this line:
$this->smilies_cache[$smilie['find']] = "<img src=\"{$this->base_url}{$smilie['image']}\" style=\"vertical-align: middle;\" border=\"0\" alt=\"{$smilie['name']}\" title=\"{$smilie['name']}\" />";

However keep in mind that by doing this you'll loose any remote smilies you may be using. I would recommend waiting for a proper fix if thats important to you.
Thanks G33K.