I agree with Stefan. Patching your forum is only meant to be a temporary measure - the core number changes are so that users know which version you're using (if you have version numbers displaying in the footer).
You can use a diff tool to figure out the changes between the core files or see the corresponding tickets in the development tracker.
(2011-04-17, 05:46 PM)awww Wrote: [ -> ]i did the same with out calling install/upgrade.php didnt know it made a difference because when i go in the control panel it says you have upgraded
You are
required to run the upgrade script. This is to allow the default templates to be updated with the security fixes. If you create a new template set, or revert the affected templates back to their defaults, then you'll be losing the functionality.
So what about this posted below, and your reply in it Tom. Does simply replacing that single JS file fix the issue with IE9?
Quote:I replaced jscripts/prototype.js with the current version of Prototype 1.7 from prototypejs.org
For me that fixes the double quick reply, and other problems
Link:
http://community.mybb.com/thread-90278-p...#pid658774
==========
Ah! scrap what I said above, I saw your next reply further down we're you say adding that tag to headincludes template is still the best workaround instead.
Adding the tag was only meant to be a temporary fix, the whole reason Prototype was updated was to fix the IE9 compatibility issues.
OK, can I ask then! If I replace that file on my forum in the JS folder. Will that fix the IE9 issue for me, or is there a lot more to it than just replacing one file?
I was going to replace the file hoping that solved that problem for me, but then I read another reply made by Tomm M a little further down in that same thread after a person asked if that could be considered as a proper fix here.
http://community.mybb.com/thread-90278-p...#pid658788
http://community.mybb.com/thread-90278-p...#pid658820
Tomm M Wrote:Definitely not. I've been looking into it this morning and although it helps things like double posting it doesn't solve all the problems. The best workaround is still the compatibility tag placed in the headerinclude template.
But of course they was both talking about using the Prototype file at the time taken from the site creating it, not the one now included in the download package with MyBB.
Oh OK, I thought Tom had said somewhere that the update to Prototype fixed it all... but if you've not replaced the file yet then do it and see what it does, it wouldn't have been supplied if it wasn't going to improve anything at all.
Well, looking at what Tomm M said in that thread, even though they was both talking about the "Prototype" file downloaded direct from their JS site. It still leaves you with the impression the best option is the TAG way still. Unless somebody here like (Tomm M) can confirm the Prototype file has since been edited even further included in the MyBB download package now to fix all the issues, and not just some like before.
As it's still 1.7 version of the Prototype file included - just as they used before.
Please, read this thread from this post onwards:
http://community.mybb.com/thread-90278-p...#pid658774
Both general.js and thread.js had to be modified to work properly in IE9, as well as an upgrade to Prototype 1.7 (which fixes 90% of the problems by itself). The corresponding issue can be found here:
http://dev.mybb.com/issues/1501
If you run through the revisions, you're able to see exactly what was changed for the javascript to be compatible with IE9.
There are lots more improvements to the javascript planned for a later 1.6 maintenance release which will upgrade much of it to take advantage of Prototype 1.7 (and to have some degree of coding standard). Stefan wasn't kidding when he said that making the next updates will be more complicated - running the changed files is really the best option.