MyBB Community Forums

Let me guess, they are using IE?
The hyphen in the greeting is there is a hyphen after '</script>'.

Try this:

<SCRIPT LANGUAGE="JavaScript">
<!-- Original:  Robert Ison -->
<!-- Web Site:  http://www.infosourcetraining.com -->

<!-- This script and many more are available free online at -->
<!-- The JavaScript Source!! http://javascript.internet.com -->

<!-- Begin
var datetoday = new Date();
var timenow=datetoday.getTime();
datetoday.setTime(timenow);
thehour = datetoday.getHours();
if (thehour > 18) display = "Evening";
else if (thehour >12) display = "Afternoon";
else display = "Morning";
var greeting = ("<b>Good " + display + "!</b>");
document.write(greeting);
//  End -->
</script> -

,{$lang->welcome_back} (<a href="{$mybb->settings['bburl']}/usercp.php"><strong>{$lang->welcome_usercp}</strong></a>{$modcplink}{$admincplink} &mdash; <a href="{$mybb->settings['bburl']}/member.php?action=logout&amp;logoutkey={$mybb->user['logoutkey']}">{$lang->welcome_logout}</a>)<br />
                <span class="links">
                    <a href="#" onclick="MyBB.popupWindow('{$mybb->settings['bburl']}/misc.php?action=buddypopup', 'buddyList', 350, 350);">{$lang->welcome_open_buddy_list}</a>
                </span>
                <a href="{$mybb->settings['bburl']}/search.php?action=getnew">{$lang->welcome_newposts}</a> | <a href="{$mybb->settings['bburl']}/search.php?action=getdaily">{$lang->welcome_todaysposts}</a> | <a href="search.php?action=finduserthreads&uid={$mybb->user['uid']}">View my threads</a> | <a href="search.php?action=finduser&uid={$mybb->user['uid']}">View my posts</a> | <a href="{$mybb->settings['bburl']}/private.php">{$lang->welcome_pms}</a> {$lang->welcome_pms_usage}

Or you could use this solution: http://community.mybb.com/thread-92536-p...#pid675298 which, if it works for you, it works for anyone