MyAlerts - a notification/alert system for MyBB
In the very new version in github it seems that you have forgotten to put "?>" at the very end of language file (myalerts.lang.php).

(2012-10-11, 08:26 AM)euantor Wrote: 1. The same thing happens everywhere else in MyBB
Somehow I managed to see it only on this plugin. Big Grin Sorry, my bad.

(2012-10-11, 08:26 AM)euantor Wrote: 2. This is a known issue. I'm still trying to think of the best way to fix it. People complained about the old solution where alerts were marked read by opening the popup too.
Yes, it might be like that.. :/

Also one more small sugestion: instead of alert text being "Person quoted you in a post. (Today 11:47)" it might say "Person quoted you in a thread Thread name. (Today 11:47)". It would be more informative. Smile

Have I said that myalerts is great great great plugin and well done one?
(2012-10-11, 08:44 AM)loveley Wrote: In the very new version in github it seems that you have forgotten to put "?>" at the very end of language file (myalerts.lang.php).

The php doesn't need the closing tag.
As tecca said, PHP does not need the closing tag. It's actually considered best not to include it unless you're mixing PHP and HTML in a single file.

I can change that text, I'll do that for the next version Smile
This user has been denied support. This user has been denied support.
(2012-10-10, 03:58 PM)euantor Wrote: Sorry, what?
Ok it work with PluginLibrary 10!
but. how to rename it?
   
[Image: logo.png]
MYBB Vietnamese Support Community
Yeah, you need PluginLibrary 9 or newer. 10 is preferred.

You can change the text via the language files.
This user has been denied support. This user has been denied support.
thanks you! but the text in myalerts_headericon templates ^^!
so cool ^^!
[Image: logo.png]
MYBB Vietnamese Support Community
That should also be in the language file Smile
I still have the older version (maybe you changed it), but I couldn't find it in the language file. I'll admit I didn't look very hard though. I changed Alerts (0) to Notices (0) from the core file itself.
Fairly sure it's in the language file. I tried not to hardcode anything at all (except from a few of the error messages where I got lazy).
This user has been denied support. This user has been denied support.
Warning: cache error!?
It working a few minutes, then i can not access mybb.vn/community/Thread-MyBB-1-6-8.html?action=lastpost
but, dropping line ?action=lastpost, back to work??????
[Image: logo.png]
MYBB Vietnamese Support Community


Forum Jump:


Users browsing this thread: 1 Guest(s)