+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Community Archive (https://community.mybb.com/forum-106.html)
+--- Forum: Archived Forums (https://community.mybb.com/forum-143.html)
+---- Forum: Archived Development and Support (https://community.mybb.com/forum-155.html)
+----- Forum: MyBB 1.6 (https://community.mybb.com/forum-138.html)
+------ Forum: 1.6 General Support (https://community.mybb.com/forum-127.html)
+------ Thread: Need code check please! (/thread-146005.html)
Need code check please! - marcus123 - 2013-09-28
Guys I want to use this code for the login popup, it works and everything doesn't need massive jquery file. Could you please check it for security issues?
<span class="welcome" id="quick_login">{$lang->welcome_guest} <a href="#login_form" id="login_pop" class="login">{$lang->welcome_login}</a> <a href="{$mybb->settings['bburl']}/member.php?action=register" class="register">{$lang->welcome_register}</a></span>
<a href="#" class="overlay" id="login_form"></a>
<div class="popup">
<font size="4">Welcome Back!</font><br>
Type your Username and Password.
<div>
<br>
<form method="post" action="member.php">
<input type="hidden" name="action" value="do_login">
<input type="hidden" name="url" value="{$mybb->settings['bburl']}/index.php">
<input type="hidden" name="quick_login" value="1">
<input type="text" name="quick_username" id="quick_login_username" value="Username" class="textbox" onfocus="if(this.value == 'Username') { this.value=''; }" onblur="if(this.value == '') { this.value='Username'; }"> <br><br>
<input type="password" name="quick_password" id="quick_login_password" value="{$lang->login_password}" class="textbox" onfocus="if(this.value == '{$lang->login_password}') { this.value=''; }" onblur="if(this.value == '') { this.value='{$lang->login_password}'; }">
<br><br><input type="submit" name="submit" value="Log in" class="button_accedi">
<span class="remember_me">
<input type="checkbox" name="quick_remember" id="quick_login_remember" value="yes" class="checkbox" checked="checked">
<label for="quick_login_remember"> {$lang->remember_me}</label>
</span>
      
<a href="{$mybb->settings['bburl']}/member.php?action=lostpw">{$lang->lost_password}</a>  
</form>
<a class="close" href="#close"></a>
</div>
RE: Need code check please! - Destroy666 - 2013-09-28
Which security holes are you considering? I don't see anything suspicous here.
The only things, which probably needs removal are        and   . If you use CodePress, I recommend to disable it in ACP Preferences.
RE: Need code check please! - marcus123 - 2013-09-28
Destroy baby you are awesome I will remove "       and   "
Thanks