MyBB Community Forums
[Pushed] closed threads - Printable Version

+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Development (https://community.mybb.com/forum-161.html)
+--- Forum: MyBB 1.8 Development (https://community.mybb.com/forum-165.html)
+---- Forum: 1.8 Bugs and Issues (https://community.mybb.com/forum-157.html)
+----- Forum: Pushed (https://community.mybb.com/forum-183.html)
+----- Thread: [Pushed] closed threads (/thread-159466.html)

Pages: 1 2


closed threads - ATofighi - 2014-09-15

Hi,
In closed threads, "New Reply" button don't change to "Thread Closed" button.

Fixes:
https://github.com/ATofighi/mybb_/compare/mybb:feature...patch-2?quick_pull=1


RE: closed threads bug - eNvy - 2014-09-15

Isn't a bug, if you see the thread with an administration account, you will see the "New reply" button, and the quick reply will be light-red.

But if you see the thread with a normal account, the button change to "closed" and you can't reply.


RE: closed threads bug - ATofighi - 2014-09-15

You're right but I think a link to a not permision page isn't useful! Undecided


RE: closed threads - Destroy666 - 2014-09-15

(2014-09-15, 01:05 PM)My-BB.Ir Wrote: You're right but I think a link to a not permision page isn't useful! Undecided

What do you mean? If you can reply to the closed thread (so there shouldn't be 'no permission' page), showthread_newreply is displayed. If you can't reply to it, showthread_newreply_closed is shown instead. This is intended and it works fine for me. Could you elaborate?


RE: closed threads - ATofighi - 2014-09-15

(2014-09-15, 04:05 PM)Destroy666 Wrote:
(2014-09-15, 01:05 PM)My-BB.Ir Wrote: You're right but I think a link to a not permision page isn't useful! Undecided

What do you mean? If you can reply to the closed thread (so there shouldn't be 'no permission' page), showthread_newreply is displayed. If you can't reply to it, showthread_newreply_closed is shown instead. This is intended and it works fine for me. Could you elaborate?
Now,
if (thread is closed && you can reply to closed threads) { You see "New Reply" button }
if(thread is closed && you can't reply to closed threads) { You see "Closed Thread" button => "Closed thread" button links to a "No Permission" }


RE: closed threads - Destroy666 - 2014-09-15

Oh, I see, but then your PR doesn't fix it because the link is inside the showthread_newreply_closed template: https://github.com/mybb/mybb/blob/feature/install/resources/mybb_theme.xml#L11328

It always linked to a no permission page as far as I remember, so I'm not sure if it should be considered a bug. But I agree that removing it would be better.
EDIT: ^ yep, 1.6.x had it like this too: https://github.com/mybb/mybb/blob/master/install/resources/mybb_theme.xml#L3713


RE: closed threads - ATofighi - 2014-09-15

(2014-09-15, 05:18 PM)Destroy666 Wrote: Oh, I see, but then your PR doesn't fix it because the link is inside the showthread_newreply_closed template: https://github.com/mybb/mybb/blob/feature/install/resources/mybb_theme.xml#L11328

It always linked to a no permission page as far as I remember, so I'm not sure if it should be considered a bug. But I agree that removing it would be better.
EDIT: ^ yep, 1.6.x had it like this too: https://github.com/mybb/mybb/blob/master/install/resources/mybb_theme.xml#L3713
I said: "Thread Closed" button should display for peoples can reply to closed threads and don't display anything for others.


RE: closed threads - Omar G. - 2014-09-15

IIRC it redirected to an error_no_permission() page in 1.6 but now it uses an error() page. Unsure why the change.

Basically, the page/button is there to encourage users to register/login, which doesn't really happens with the error() page.


RE: closed threads - Destroy666 - 2014-09-15

(2014-09-15, 07:18 PM)My-BB.Ir Wrote:
(2014-09-15, 05:18 PM)Destroy666 Wrote: Oh, I see, but then your PR doesn't fix it because the link is inside the showthread_newreply_closed template: https://github.com/mybb/mybb/blob/feature/install/resources/mybb_theme.xml#L11328

It always linked to a no permission page as far as I remember, so I'm not sure if it should be considered a bug. But I agree that removing it would be better.
EDIT: ^ yep, 1.6.x had it like this too: https://github.com/mybb/mybb/blob/master/install/resources/mybb_theme.xml#L3713
I said: "Thread Closed" button should display for peoples can reply to closed threads and don't display anything for others.

But then the people won't be able to see that the thread is closed from showthread - the button provides that information. Not a good solution, the current code is better.

If anything should be changed, then I'd remove the link from the button, nothing else.


RE: closed threads - Eldenroot - 2014-10-11

Maybe better to add a new button for users with permissions to reply to closed threads