MyBB Community Forums
[Rejected] Profile saved, redirect error.. - Printable Version

+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Development (https://community.mybb.com/forum-161.html)
+--- Forum: MyBB 1.8 Development (https://community.mybb.com/forum-165.html)
+---- Forum: 1.8 Bugs and Issues (https://community.mybb.com/forum-157.html)
+----- Forum: Rejected (https://community.mybb.com/forum-184.html)
+----- Thread: [Rejected] Profile saved, redirect error.. (/thread-161147.html)



Profile saved, redirect error.. - SeNCeR - 2014-10-12

usercp.php No redirect..
redirect("usercp.php?action=profile", $lang->redirect_profileupdated);

usercp.lang.php  There redirect
$l['redirect_profileupdated'] = "Thank you, your profile has been updated successfully.<br />You will now be returned to the User CP.";


one of the options wrong..


RE: Profile saved, redirect error.. - Jones H - 2014-10-12

Why was this posted in "Pushed"? Also what is the issue here? I can't see any from what you've posted.


RE: Profile saved, redirect error.. - Destroy666 - 2014-10-12

Profile editor is a part of User CP, so the sentence from the language file is still true... Doesn't matter that it's not the main page. Rejecting.


RE: Profile saved, redirect error.. - Omar G. - 2014-10-12

It should probably say you will be returned back, since that is what it does, apparently.


RE: Profile saved, redirect error.. - Destroy666 - 2014-10-12

(2014-10-12, 12:23 PM)Omar G. Wrote: It should probably say you will be returned back, since that is what it does, apparently.

Return = go back. "Return back" wouldn't be more proper, check http://forum.wordreference.com/showthread.php?t=1798241&langid=21


RE: Profile saved, redirect error.. - Omar G. - 2014-10-12

$l['redirect_profileupdated'] = "Thank you, your profile has been updated successfully.<br />You will now be returned to the User CP Profile settings.";



RE: Profile saved, redirect error.. - Eldenroot - 2014-10-12

I agree with text change


RE: Profile saved, redirect error.. - SeNCeR - 2014-10-13

(2014-10-12, 11:44 AM)Destroy666 Wrote: Profile editor is a part of User CP, so the sentence from the language file is still true... Doesn't matter that it's not the main page. Rejecting.

Why in language files then it says User CP redirected? The language file needs to be changed.


RE: Profile saved, redirect error.. - Destroy666 - 2014-10-13

(2014-10-13, 03:05 PM)SeNCeR Wrote:
(2014-10-12, 11:44 AM)Destroy666 Wrote: Profile editor is a part of User CP, so the sentence from the language file is still true... Doesn't matter that it's not the main page. Rejecting.

Why in language files then it says User CP redirected?

The answer is in the quote... The user is redirected to a part of User CP and the redirect string doesn't negate that. Feel free to change it to something more descriptive, but I see no point.