MyBB Community Forums
[Pushed] Inconsistent checks in db classes - Printable Version

+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Development (https://community.mybb.com/forum-161.html)
+--- Forum: MyBB 1.8 Development (https://community.mybb.com/forum-165.html)
+---- Forum: 1.8 Bugs and Issues (https://community.mybb.com/forum-157.html)
+----- Forum: Pushed (https://community.mybb.com/forum-183.html)
+----- Thread: [Pushed] Inconsistent checks in db classes (/thread-171782.html)



Inconsistent checks in db classes - Jones H - 2015-06-11

Most function get the query as parameter. While MySQL(i) and PgSQL simpy call the respictive functions then, SQLite always has "is_object" checks. Either all classes/function should get a proper check ($query instanceof ...) or the checks should be removed.


RE: Inconsistent checks in db classes - Jones H - 2015-06-29

Hi,

Thank you for your report. We have pushed this issue to our Github repository for further analysis where you can track our commits and progress with fixing this bug. Discussions regarding this bug may also take place there too.

Follow this link to visit the issue on Github: https://github.com/mybb/mybb/issues/2115

Thanks for contributing to MyBB!

Regards,
The MyBB Group