MyBB Community Forums
[Rejected] [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - Printable Version

+- MyBB Community Forums (https://community.mybb.com)
+-- Forum: Development (https://community.mybb.com/forum-161.html)
+--- Forum: MyBB 1.8 Development (https://community.mybb.com/forum-165.html)
+---- Forum: 1.8 Bugs and Issues (https://community.mybb.com/forum-157.html)
+----- Forum: Rejected (https://community.mybb.com/forum-184.html)
+----- Thread: [Rejected] [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) (/thread-218506.html)

Pages: 1 2


[MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - GasmoN - 2018-07-06

1. Wrong language code

Bug: "Closed Thread" text is missing next to the icon.
Bug Screenshot:  http://prntscr.com/k3h4iz
Fix Screenshot:  http://prntscr.com/k3h5q2
Fix tutorial:  Go to ACP > Templates & Style > Templates > *Your Theme* Templates > Forum Display Templates > forumdisplay_threadlist

Now find this code 
<dd><span class="thread_status lockfolder" title="{$lang->locked_thread}">&nbsp;</span> {$lang->locked_thread}</dd>
and replace it with this code
<dd><span class="thread_status lockfolder" title="{$lang->locked_thread}">&nbsp;</span> {$lang->closed_thread}</dd>

Explanation: This is happening becouse in forumdisplay_threadlist is written {$lang->locked_thread} and in your language file you don't have locked_thread but closed_thread as you can see on this picture -> http://prntscr.com/k3hef3
How we fixed it: We just replaced second {$lang->locked_thread} code with {$lang->closed_thread} code
TIP: If you can't find this code by pasting it into search bar (CTRL + F) try to search for {$lang->locked_thread} only by pasting it into search bar.

2. Missing forum icons

Bug: Closed forum icons doesn't display
Bug Screenshot: https://prnt.sc/k3h8du
Fix Screenshot: http://prntscr.com/k3hago
Fix tutorial:  Go to ACP > Templates & Style > Themes > *Your Theme* > thread_status.css and click on Edit Stylesheet: Advanced Mode

Now, in the bottom of your .css file add this code


.thread_status.dot_closefolder {
    position:relative;
}

.thread_status.dot_closefolder:before {
	color: #adadad;
	position: absolute;
	background-position: 0 -220px;
	content: "\f023";
	text-shadow: 1px 1px 0px #111;
	font-family: FontAwesome;
	font-size: 16px;
}


Explanation: This is happening becouse when you load page, dot_closefolder class is called, as you can see on this picture -> http://prntscr.com/k3hg4w but, since in your thread_status.css insted of dot_closefolder you have dot_lockfolder as you can see on picture -> http://prntscr.com/k3hhkm icons are not displaying.
What we did here: We are simply copied dot_lockfolder template and pasted at the bottom of our .css file. 
Then we just renamed it into dot_closefolder


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - snakeoilos - 2018-07-07

(2018-07-06, 10:25 PM)GasmoN Wrote: Explanation: This is happening becouse in forumdisplay_threadlist is written {$lang->locked_thread} and in your language file you don't have locked_thread but closed_thread as you can see on this picture -> http://prntscr.com/k3hef3
How we fixed it: We just replaced second {$lang->locked_thread} code with {$lang->closed_thread} code
TIP: If you can't find this code by pasting it into search bar (CTRL + F) try to search for {$lang->locked_thread} only by pasting it into search bar.
Nice. Didn't noticed that at all.
In my theme {$lang->locked_thread} also appears in
  • usercp_subscriptions

Also, look for all instances of {$lang->forum_locked} and change them to {$lang->forum_closed}.. I only have this in "Index Page Templates"/Index

Update on #2:
There're locked threads, and locked forums. If you have locked forums your custom themes will not show the padlock. To fix, edit global.css in advanced mode, and look for all instances of ".forum_offlock" and change it to ".forum_offclose". Repeat the same global change in your template "Index Page Templates"/index.


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - effone - 2018-07-07

Good job. Include other issues as well like report error, login issues. This will be helpful until we get a fixed release ...


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - StefanT - 2018-07-07

(2018-07-06, 10:25 PM)GasmoN Wrote: Now, in the bottom of your .css file add this code


.thread_status.dot_closefolder {
    position:relative;
}

.thread_status.dot_closefolder:before {
	color: #adadad;
	position: absolute;
	background-position: 0 -220px;
	content: "\f023";
	text-shadow: 1px 1px 0px #111;
	font-family: FontAwesome;
	font-size: 16px;
}
This is highly customized code and won't work with most of the themes. Why not just changing the CSS class instead of adding new code?


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - PT82 - 2018-07-07

Thanks, and how i can repair not showing rank banners in groups ?
https://community.mybb.com/thread-218479.html


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - effone - 2018-07-07

(2018-07-07, 07:24 AM)PT82 Wrote: Thanks, and how i can repair not showing rank banners in groups ?
https://community.mybb.com/thread-218479.html

Here are the changes to make filewise.
https://github.com/mybb/mybb/pull/3315/files

Note: Its under testing and may be more work is needed on it.


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - PT82 - 2018-07-07

Thanks, I'll try to fix it myself, can I ask when the fix is scheduled?


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - effone - 2018-07-07

It likely to be tested and merged by today itself.


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - PT82 - 2018-07-07

Perfect, thanks !!


RE: [MyBB 1.8.16] List of bugs I found for custom themes (And tutorial to fix them) - BRITIANA - 2018-07-07

please add fix about group image and star they are not showing

its bug