[font="droid sans", sans-serif]

(2020-09-27, 11:16 AM)nixer55 Wrote: Might be mistaken, but this looks like the issue I posted about back in April.

1. The 'redundant tags on paste of unformatted text' bug.
   
   Description: In WYSIWYG mode, on pasting unformatted text into the editor which was cut/copied from elsewhere within the editor, some browsers (e.g., Chrome and Microsoft Edge) generate redundant font+size+color attributes in the paste data whose values reflect the editor's default style (based on the default stylesheet jscripts/sceditor/styles/jquery.sceditor.mybb.css). Other browsers (e.g., Firefox) don't, and are not subject to this bug. This confirms noyle's observation/finding above. It is also the bug to which Omar's suggestion above applies: let's disable the addition of these tags. And it is the first aspect of the bug identified in the post to which nixer55 linked above.
   
   How to reproduce: In Chrome or Microsoft Edge, bring up a new editor window through a page such as a New Reply page. Deselect Source mode if it is selected, such that the editor is in WYSIWYG mode. Now, type some text into it, such as "Blah". Do not style or format that text in any way. Now, select it all, cut it, then immediately paste it, and switch to Source mode. You will see that it has had font, color, and size MyCode tags added to it even though it was unformatted and unstyled prior to being pasted, and thus should not have had any MyCode tags applied to it.
   
   Impact: Mild-moderate. Not detectable in WYSIWYG mode (except in the form of bug #2 below); irritating when switching to Source mode.
   
   
2. The 'reduced size on paste of unformatted text' bug.
   
   Description: As above, but with the added observation that under those same prone browsers (e.g., Chrome and Microsoft Edge), when the unformatted text cut/copied from elsewhere in the editor in WYSIWYG mode is pasted back into it, its default size of 14px (redundantly generated in the pasted data by these browsers) as styled by the default stylesheet (jscripts/sceditor/styles/jquery.sceditor.mybb.css) does not match any of the sizes supported by MyBB's customisation of SCEditor, such that the editor picks the "best fit" out of those sizes, which is in fact smaller than 14px. Again, other browsers (e.g., Firefox) aren't affected, again confirming noyle's observation/finding above. This is the second aspect of the bug identified in the post to which nixer55 linked above.
   
   How to reproduce: As above, but note that before switching to Source mode, the pasted text "Blah" is smaller than it was when it was cut. Also note that after switching to Source mode, the default attribute of the size tag is "small", rather than the size specified by default stylesheet, "14px" (and thus infer that "small" and "14px" are different font sizes).
   
   Impact: Mild-moderate. It is annoying in WYSIWYG mode to have to re-select such pasted text and click the "Remove Formatting" button to get it back to its original (unformatted) size.
   
   
3. The 'double quotes in font lists' bug.
   
   Description: Sometimes, in scenarios the criteria of which I haven't yet rigorously identified, when pasting text into the WYSIWYG editor, its specified font is actually a comma-separated list of two or more fonts, and at least one of the fonts in that comma-separated list is enclosed in double quotes. When the post is posted, the associated MyBB font tag(s) is/are not rendered by MyBB's PHP parser, because that parser doesn't support double-quotes within the comma-separated list of fonts of a MyCode font tag. (This is the bug which my plugin above addresses for posts which have already been posted).
   
   How to reproduce: In any browser, bring up a new editor window through a page such as a New Reply page. Select Source mode. Paste the following MyCode into the editor, after first replacing the curly braces with square braces (since I am posting this on a MyBB forum, I can't paste valid MyCode tags as they would then be rendered):
   
   {font=Test, "Test two"}Blah{/font}
   
   Switch out of Source mode and then back into it. Confirm that the code has not changed. Then submit or preview the post. Notice that in the rendered post, the raw font tag shows up unrendered.
   
   Impact: Moderate-severe. There can at times be so many of these unrendered font tags that the post once posted is effectively unreadable.
   

				return '[font=' + this.stripQuotes(font) + ']' + content + '[/font]';

				if (font[0] == '"' && font[font.length-1] == '"' && (font.match(/"/g) || []).length == 2) {
					font = font.substr(1, font.length-2);
				}
				font = font.replace(/"/g, "'");
				return '[font=' + font + ']' + content + '[/font]';